Support customizing prop wire name #4591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
|
API change check APIView has identified API level changes in this PR and created following API reviews. Microsoft.Generator.CSharp |
jorgerangel-msft
requested review from
m-nash and
JoshLove-msft
as code owners
packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Providers/TypeProvider.cs
Outdated
Show resolved
Hide resolved
packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Providers/TypeProvider.cs
Outdated
Show resolved
Hide resolved
packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Providers/TypeProvider.cs
Outdated
Show resolved
Hide resolved
packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Providers/TypeProvider.cs
Outdated
Show resolved
Hide resolved
packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Providers/TypeProvider.cs
Outdated
Show resolved
Hide resolved
…tom-serialized-name
…tom-serialized-name
jorgerangel-msft
commented
Oct 4, 2024
...harp/generator/Microsoft.Generator.CSharp.Customization/src/CodeGenSerializationAttribute.cs
Outdated
Show resolved
Hide resolved
...harp/generator/Microsoft.Generator.CSharp.Customization/src/CodeGenSerializationAttribute.cs
Show resolved
Hide resolved
JoshLove-msft
approved these changes
Oct 4, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
Adds a missing setter to the property which was overlooked as part of #4591.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for customizing a model property's serialization name via the
CodeGenSerializationattribute.supports: #4264