-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check unallow keys in @info decorator #4505
Merged
timotheeguerin
merged 23 commits into
microsoft:main
from
skywing918:InfoUnallowKeyChecker
Sep 30, 2024
Merged
Check unallow keys in @info decorator #4505
timotheeguerin
merged 23 commits into
microsoft:main
from
skywing918:InfoUnallowKeyChecker
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skywing918
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
September 24, 2024 03:12
Co-authored-by: Timothee Guerin <[email protected]>
…/typespec into InfoUnallowKeyChecker
wanlwanl
reviewed
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left 2 minor comments
timotheeguerin
approved these changes
Sep 27, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Sep 27, 2024
timotheeguerin
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3887