-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Import typespec project into a single file #4383
base: main
Are you sure you want to change the base?
Conversation
❌ There is undocummented changes. Run The following packages have changes but are not documented.
Show changes |
packages/importer/cmd/cli.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this make sense as a separate package and cli?
packages/importer/test.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
You can try these changes here
|
@@ -109,10 +109,6 @@ export async function resolveModule( | |||
const { baseDir } = options; | |||
const absoluteStart = baseDir === "" ? "." : await realpath(resolvePath(baseDir)); | |||
|
|||
if (!(await isDirectory(host, absoluteStart))) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not possible to check with urls and doesn't bring too much values apart from figuring out you passed the wrong value when developping.
@@ -1975,7 +1975,10 @@ function printItemList<T extends Node>( | |||
* @param options Prettier options | |||
* @returns Raw text in the file for the given node. | |||
*/ | |||
function getRawText(node: TextRange, options: TypeSpecPrettierOptions) { | |||
function getRawText(node: TextRange, options: TypeSpecPrettierOptions): string { | |||
if ("rawText" in node) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this way of setting the syntax for basic nodes where they can have rawText
instead of relying on the pos
and end
and the whole file making writing tsp from an AST impossible
Hi @timotheeguerin. Your PR has had no update for 30 days and it is marked as a stale PR. If it is not updated within 30 days, the PR will automatically be closed. If you want to refresh the PR, please remove the |
1 similar comment
Hi @timotheeguerin. Your PR has had no update for 30 days and it is marked as a stale PR. If it is not updated within 30 days, the PR will automatically be closed. If you want to refresh the PR, please remove the |
Imported