-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow trailing commas for tuple and array literals and update formatter to put them #4373
base: main
Are you sure you want to change the base?
Allow trailing commas for tuple and array literals and update formatter to put them #4373
Conversation
You can try these changes here
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is also another issue that just says to do that for all list, so wondering if I should split this into 2 prs.
- remove the resitriction (allow parsing trailing separator for all lists)
2.update formatter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move the restrition removal to another PR and we can keep this one for the formatting change #4837
Hi @timotheeguerin. Your PR has had no update for 30 days and it is marked as a stale PR. If it is not updated within 30 days, the PR will automatically be closed. If you want to refresh the PR, please remove the |
1 similar comment
Hi @timotheeguerin. Your PR has had no update for 30 days and it is marked as a stale PR. If it is not updated within 30 days, the PR will automatically be closed. If you want to refresh the PR, please remove the |
fix #2284
Two changes: