Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: OpenAPI3 params are explode: true by default #4168

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Aug 13, 2024

fix #4165

@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:openapi3 Issues for @typespec/openapi3 emitter label Aug 13, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Aug 13, 2024

❌ There is undocummented changes. Run chronus add to add a changeset or click here.

The following packages have changes but are not documented.

  • @typespec/http
  • @typespec/rest

The following packages have already been documented:

  • @typespec/openapi3
Show changes

@typespec/openapi3 - fix ✏️

Fix: query params are explode: true by default in OpenAPI 3.0

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@timotheeguerin timotheeguerin merged commit 7797b72 into microsoft:release/august-2024 Aug 13, 2024
9 of 18 checks passed
@timotheeguerin timotheeguerin deleted the fix/openapi-explode-query-false branch August 13, 2024 16:22
@gabrielpoca
Copy link

Hey 👋 just a heads-up to anyone else who lands here: this is kinda of a breaking change. I know the spec wasn't correct, but it changes the default behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:openapi3 Issues for @typespec/openapi3 emitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants