Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with examples #3875

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Jul 17, 2024

fix #3874 (Examples not working with nested model in array)
fix #3872 (Examples not working when type is union)

Additionally found the following issues that this fix:

  • not working when type was unknown
  • not working with Record

@microsoft-github-policy-service microsoft-github-policy-service bot added the compiler:core Issues for @typespec/compiler label Jul 17, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 17, 2024

All changed packages have been documented.

  • @typespec/compiler
Show changes

@typespec/compiler - fix ✏️

Fix issues with examples not working with Array, Record, Union and unknown types

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@timotheeguerin timotheeguerin enabled auto-merge July 17, 2024 16:11
@timotheeguerin timotheeguerin added this pull request to the merge queue Jul 17, 2024
Merged via the queue into microsoft:main with commit 8cd4ed0 Jul 17, 2024
22 checks passed
@timotheeguerin timotheeguerin deleted the fix/examples-issues branch July 17, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:core Issues for @typespec/compiler
Projects
None yet
3 participants