Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not cast model expression to object value if the constraint is allowing the type #3824

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Do not cast model expression to object value if the constraint is allowing the type #3824

merged 4 commits into from
Jul 11, 2024

Conversation

timotheeguerin
Copy link
Member

fix #3576

@microsoft-github-policy-service microsoft-github-policy-service bot added the compiler:core Issues for @typespec/compiler label Jul 11, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 11, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/compiler
Show changes

@typespec/compiler - fix ✏️

Do not cast model expression to object value if the constraint is allowing the type

@azure-sdk
Copy link
Collaborator

You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/3824/

Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/3824/

@timotheeguerin timotheeguerin enabled auto-merge July 11, 2024 20:01
@timotheeguerin timotheeguerin added this pull request to the merge queue Jul 11, 2024
Merged via the queue into microsoft:main with commit f3afdfa Jul 11, 2024
22 checks passed
@timotheeguerin timotheeguerin deleted the fix/expression-cast-to-object branch July 11, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisradek chrisradek chrisradek approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

Assignees
No one assigned
Labels
compiler:core Issues for @typespec/compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Models assigned where constraint is mix of "value unknown" and "unknown" throws deprecation warning
3 participants
@timotheeguerin @azure-sdk @chrisradek