-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeGraph Viewer V2 #3713
TypeGraph Viewer V2 #3713
Conversation
All changed packages have been documented.
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/3713/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/3713/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started commenting on some of the hooks in the react-components
package - many of them seem to have an inexhaustive list of dependencies. In some cases I'm not sure if that's intended or not (e.g. useControllableValue
has a useMemo
with an empty dependency list - which means isControlled
won't change if controlledValue
changes to/from undefined
.)
Might be worth updating the eslint rules to include the react-hooks
rules from eslint-plugin-react-hooks
:
export function getTypeScriptProjectRules(root) {
return tsEslint.config({
files: ["**/*.ts", "**/*.tsx"],
ignores: ["packages/http-client-csharp/**/*"], // Ignore isolated modules
plugins: {
deprecation,
"react-hooks": reactHooks,
},
languageOptions: {
parserOptions: {
project: "./tsconfig.json",
tsconfigRootDir: root,
},
},
rules: {
// Only put rules here that need typescript project information
"@typescript-eslint/no-floating-promises": "error",
"deprecation/deprecation": ["warn"],
"react-hooks/rules-of-hooks": "error",
"react-hooks/exhaustive-deps": "warn",
},
});
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really like these UI updates!
https://cadlplayground.z22.web.core.windows.net/prs/3713/