Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some styles in the playground with overflow #3542

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Fix some styles in the playground with overflow #3542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d333c03
Fix some styles in the playground with overflow
timotheeguerin Jun 6, 2024
09cbb65
Create fix-playground-styles-overflow-2024-5-6-19-45-49.md
timotheeguerin Jun 6, 2024
fc1f2a1
Fix typo
timotheeguerin Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .chronus/changes/fix-playground-styles-overflow-2024-5-6-19-45-49.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
# Change versionKind to one of: internal, fix, dependencies, feature, deprecation, breaking
changeKind: fix
packages:
- "@typespec/playground"
---

Fix issue where hover tooltip would be cropped or not visible
2 changes: 1 addition & 1 deletion packages/playground/src/react/editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export const Editor: FunctionComponent<EditorProps> = ({ model, options, actions
return (
<div
className="monaco-editor-container"
style={{ width: "100%", height: "100%", overflow: "hidden" }}
style={{ width: "100%", height: "100%" }}
ref={editorContainerRef}
data-tabster='{"uncontrolled": {}}' // https://github.com/microsoft/tabster/issues/316
></div>
Expand Down
1 change: 1 addition & 0 deletions packages/playground/src/react/output-tabs/output-tabs.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
.tabs {
border-bottom: 1px solid var(--colorNeutralStroke1);
box-shadow: var(--shadow2);
overflow-y: auto;
}

.tab-divider {
Expand Down
5 changes: 5 additions & 0 deletions packages/playground/src/react/playground.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,8 @@
height: 100%;
overflow: hidden;
}

.edit-pane {
display: flex;
flex-direction: column;
}
2 changes: 1 addition & 1 deletion packages/playground/src/react/playground.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ export const Playground: FunctionComponent<PlaygroundProps> = (props) => {
<SplitPane sizes={verticalPaneSizes} onChange={onVerticalPaneSizeChange} split="horizontal">
<Pane>
<SplitPane initialSizes={["50%", "50%"]}>
<Pane>
<Pane className={style["edit-pane"]}>
<EditorCommandBar
host={host}
selectedEmitter={selectedEmitter}
Expand Down
Loading