Add shell: true to TSP install command. #3243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breakage due to a breaking change in node's latest incremental version. (See nodejs/node#52554 for background). Addint shell: true fixes this. Fixes microsoft#3242.
LadyCailin
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
|
Note that I don't have a mac to test in, but I tested this in WSL as well, and it works (although it works without the fix too). |
|
/azp run typespec - pr tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
❌ There is undocummented changes. Run The following packages have changes but are not documented.
Show changes |
timotheeguerin
approved these changes
Apr 26, 2024
4 tasks
This was referenced Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breakage due to a breaking change in node's latest incremental version. (See nodejs/node#52554 for background). Adding shell: true fixes this.
Fixes #3242.