Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable retries for "rush install" #2425

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Enable retries for "rush install" #2425

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba0584e
Enable retries for "rush install"
mikeharder Sep 15, 2023
2ec4fc4
Correct "rush update" to "rush install"
mikeharder Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/website-gh-pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
node-version: 18.x

- name: Install dependencies
run: node common/scripts/install-run-rush.js update
run: node common/scripts/install-run-rush.js update --max-install-attempts 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be install instead of update too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't write the script, but probably yes. rush update should typically only be run on a dev machine when creating a PR. I will update in this PR.


- name: Build
run: node common/scripts/install-run-rush.js build --to @typespec/website -v
Expand Down
2 changes: 1 addition & 1 deletion eng/pipelines/jobs/pull-request-consistency.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ steps:
versionSpec: "16.x"
displayName: Install Node.js

- script: node common/scripts/install-run-rush.js install
- script: node common/scripts/install-run-rush.js install --max-install-attempts 3
displayName: Install JavaScript Dependencies

- script: node common/scripts/install-run-rush.js change -v
Expand Down
2 changes: 1 addition & 1 deletion eng/pipelines/pr-tryit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
versionSpec: 16.x
displayName: Install Node.js

- script: node common/scripts/install-run-rush.js install
- script: node common/scripts/install-run-rush.js install --max-install-attempts 3
displayName: Install JavaScript Dependencies

- template: ./templates/build.yml
Expand Down
2 changes: 1 addition & 1 deletion eng/pipelines/templates/install.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ steps:
dotnet --version
displayName: "Log tool versions used"

- script: node common/scripts/install-run-rush.js install
- script: node common/scripts/install-run-rush.js install --max-install-attempts 3
displayName: Install JavaScript Dependencies

- script: dotnet restore
Expand Down