Don't require a global install of cadl for the IDE extension to work #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheeguerin
requested review from
bterlson,
daviwil,
nguerrera,
markcowl and
allenjzhang
as code owners
timotheeguerin
force-pushed
the
global-cadl-not-req
branch
from
7c0fc0a to
7a1995c
Compare
nguerrera
reviewed
Oct 20, 2022
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/1197/ Check the website changes at https://cadlwebsite.z1.web.core.windows.net/prs/1197/ |
nguerrera
reviewed
Oct 20, 2022
nguerrera
reviewed
Oct 20, 2022
nguerrera
approved these changes
Oct 20, 2022
|
For VS, it might not be too difficult to do a parent folder walk like resolveModule? Might capture more cases (such as opening a subfolder of a monorepo). |
yeah I guess that's right we don't need to have most of the resolveMOdule functionality just traverse parent up. I'll update |
nguerrera
reviewed
Oct 20, 2022
nguerrera
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1116
Vscode extension calls out to resolveModule to get a better result(lookup in parent dir)
VS is more basic and only lookup in
./node_modules/@cadl-lang/compiler