Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RestClientProvider should include additional status code classifiers #4865

Closed
JoshLove-msft opened this issue Oct 24, 2024 · 1 comment · Fixed by #5174
Closed

RestClientProvider should include additional status code classifiers #4865

JoshLove-msft opened this issue Oct 24, 2024 · 1 comment · Fixed by #5174
Assignees
@jorgerangel-msft
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Comments

@JoshLove-msft
Copy link
Contributor

We can get the full set of 20x status codes from the _inputClient.Operations.
@JoshLove-msft JoshLove-msft added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Oct 24, 2024
@jorgerangel-msft jorgerangel-msft mentioned this issue Oct 24, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 24, 2024
@jorgerangel-msft
[http-client-csharp] Fix: add support for 201 classifier (#4866)
3504675 
Fixes an issue where an operation with a 201 response would cause the
generator to crash since there is no corresponding classifier generated
for a 201 response.

contributes to #4865
@jorgerangel-msft jorgerangel-msft mentioned this issue Nov 4, 2024
Merged
@jorgerangel-msft
Copy link
Contributor

To clarify, we should only add the classifiers that the client requires.

swatkatz pushed a commit to swatkatz/typespec that referenced this issue Nov 5, 2024
@jorgerangel-msft
[http-client-csharp] Fix: add support for 201 classifier (microsoft#4866
bf0adc0 
)

Fixes an issue where an operation with a 201 response would cause the
generator to crash since there is no corresponding classifier generated
for a 201 response.

contributes to microsoft#4865
@jorgerangel-msft jorgerangel-msft self-assigned this Nov 19, 2024
@live1206 live1206 mentioned this issue Nov 20, 2024
Closed
@jorgerangel-msft jorgerangel-msft mentioned this issue Nov 22, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 3, 2024
@jorgerangel-msft
[http-client-csharp] Generate all req. response classifiers (#5174)
ee359ef 
This PR adds support for generating all the required response
classifiers for the generated client.

fixes: #4865
contributes to: #4903
archerzz pushed a commit to archerzz/typespec that referenced this issue Dec 17, 2024
@jorgerangel-msft
[http-client-csharp] Generate all req. response classifiers (microsof…
0d45c78 
…t#5174)

This PR adds support for generating all the required response
classifiers for the generated client.

fixes: microsoft#4865
contributes to: microsoft#4903
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorgerangel-msft jorgerangel-msft

Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[http-client-csharp] Generate all req. response classifiers jorgerangel-msft/typespec
2 participants
@JoshLove-msft @jorgerangel-msft