Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Error reported when global "tsp-server.cmd" is used or typespec.tsp-server.path is configured to "...tsp-srever.cmd" in vscode when newer nodejs is installed #4343

Closed
4 tasks done
RodgeFu opened this issue Sep 5, 2024 · 0 comments · Fixed by #4430
Closed
4 tasks done

[Bug]: Error reported when global "tsp-server.cmd" is used or typespec.tsp-server.path is configured to "...tsp-srever.cmd" in vscode when newer nodejs is installed #4343

RodgeFu opened this issue Sep 5, 2024 · 0 comments · Fixed by #4430
Assignees
@RodgeFu
Labels
bug Something isn't working ide Issues for VS, VSCode, Monaco, etc.

Comments

@RodgeFu
Copy link
Contributor

RodgeFu commented Sep 5, 2024

Describe the bug

[Bug]: a breaking change from nodejs security release. we need to set {shell: true} when spawn .cmd file, otherwilse EINVAL error would be reported.
detail can be found at: https://nodejs.org/en/blog/vulnerability/april-2024-security-releases-2

Reproduction

Error reported when global "tsp-server.cmd" is used or typespec.tsp-server.path is configured to "...tsp-srever.cmd" when new Node is installed.
image

Checklist
@RodgeFu RodgeFu added the bug Something isn't working label Sep 5, 2024
@RodgeFu RodgeFu self-assigned this Sep 5, 2024
@RodgeFu RodgeFu added ide Issues for VS, VSCode, Monaco, etc. and removed needs-area labels Sep 5, 2024
@RodgeFu RodgeFu mentioned this issue Sep 13, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 20, 2024
@RodgeFu
Use shell for execution of .cmd (tsp-server.cmd) (#4430)
0b08449 
fixes #4343. shell needs to be used for executing .cmd file in newer
nodejs version (a breaking change from nodejs security release). more
detail can be found in the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RodgeFu RodgeFu

Labels
bug Something isn't working ide Issues for VS, VSCode, Monaco, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use shell for execution of .cmd (tsp-server.cmd) RodgeFu/typespec
1 participant
@RodgeFu