Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metadata] Convey effective type from REST layer #1084

Closed
nguerrera opened this issue Sep 26, 2022 · 2 comments
Closed

[Metadata] Convey effective type from REST layer #1084

nguerrera opened this issue Sep 26, 2022 · 2 comments
Assignees
Milestone

Comments

@nguerrera
Copy link
Contributor

Currently the getEffectiveType happens in the openapi emitter and another REST-based emitter would need to replicate this. It might be nicer to convey this in the data returned from the REST layer about the routes than to require an emitter to call it on their own.

@ghost ghost added the Needs Triage label Sep 26, 2022
@allenjzhang allenjzhang added this to the Backlog milestone Oct 3, 2022
@nguerrera
Copy link
Contributor Author

nguerrera commented Oct 3, 2022

This won't work. You need to apply getEffectiveType recursively so we can't just do it on the root types and put those in the return objects from REST layer. What we should do instead is make a helper in REST layer and maybe put it in/next to MetadataInfo. This can be implemented in #1070 and documented in #1083

@nguerrera
Copy link
Contributor Author

Closing as covered by #1070 and #1083, adding notes to each.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants