Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metadata] Apply visibility in cadl-autorest emit and share code with openapi3 #1070

Closed
nguerrera opened this issue Sep 22, 2022 · 2 comments
Closed

[Metadata] Apply visibility in cadl-autorest emit and share code with openapi3 #1070

nguerrera opened this issue Sep 22, 2022 · 2 comments
Assignees
@nguerrera
Milestone
[2022] November

Comments

@nguerrera
Copy link
Contributor

Currently, only the openapi3 emitter applies visibility during emit. We should move some code to shared openapi library and implement the same visibility handling in cadl-autorest as openapi3.
@ghost ghost added the Needs Triage label Sep 22, 2022
@nguerrera nguerrera mentioned this issue Sep 22, 2022
Merged
@markcowl
Copy link
Contributor

pri: 2
est: 5

@nguerrera nguerrera mentioned this issue Oct 3, 2022
Closed
@nguerrera
Copy link
Contributor Author

We should also move a getEffectiveType helper to REST layer, nearby the rest of the metadata handling, since emitters will need to use that too. And we should document that in #1083

@nguerrera nguerrera mentioned this issue Oct 25, 2022
Closed
@nguerrera nguerrera mentioned this issue Nov 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nguerrera nguerrera

Labels
None yet
Projects
None yet
Milestone
[2022] November
Development

No branches or pull requests
3 participants
@nguerrera @markcowl @allenjzhang