fix: fixes issue with tests not being found from template (#3605)

fix [#3647](#3647) With node 22 the --test needs a glob to find files to test. As the docs a written the tests don't run or pass. This fixes it for me. --------- Co-authored-by: Timothee Guerin <[email protected]>
microsoft · Jul 8, 2024 · 245e4e6 · 245e4e6
1 parent a38126c
commit 245e4e6
Show file tree

Hide file tree

Showing 12 changed files with 39 additions and 34 deletions.
diff --git a/.chronus/changes/fix-test-path-2024-6-5-14-0-33.md b/.chronus/changes/fix-test-path-2024-6-5-14-0-33.md
@@ -0,0 +1,7 @@
+---
+changeKind: fix
+packages:
+  - "@typespec/compiler"
+---
+
+Fix templates initialized on node 22
diff --git a/docs/extending-typespec/basics.md b/docs/extending-typespec/basics.md
@@ -154,7 +154,8 @@ Alternatively, you can add these as scripts in your `package.json` to make them
     "clean": "rimraf ./dist ./temp",
     "build": "tsc -p .",
     "watch": "tsc -p . --watch",
-    "test": "node --test ./dist/test"
+    "test": "node --test ./dist/test/**/*.test.js", // Node 22+
+    "test": "node --test ./dist/test/"              // Node 18, 20
   }
 ```
 

diff --git a/eng/tsp-core/pipelines/stages/ci-stages.yml b/eng/tsp-core/pipelines/stages/ci-stages.yml
@@ -21,6 +21,9 @@ stages:
             "Node 20.x":
               nodeVersion: 20.x
 
+            "Node 22.x":
+              nodeVersion: 22.x
+
         pool:
           name: $(WINDOWSPOOL)
           image: $(WINDOWSVMIMAGE)

diff --git a/packages/compiler/templates/__snapshots__/emitter-ts/.eslintrc.yml b/packages/compiler/templates/__snapshots__/emitter-ts/.eslintrc.yml
diff --git a/packages/compiler/templates/__snapshots__/emitter-ts/eslint.config.js b/packages/compiler/templates/__snapshots__/emitter-ts/eslint.config.js
@@ -0,0 +1,11 @@
+// @ts-check
+import eslint from "@eslint/js";
+import tsEslint from "typescript-eslint";
+
+export default tsEslint.config(
+  {
+    ignores: ["**/dist/**/*", "**/.temp/**/*"],
+  },
+  eslint.configs.recommended,
+  ...tsEslint.configs.recommended
+);
diff --git a/packages/compiler/templates/__snapshots__/emitter-ts/package.json b/packages/compiler/templates/__snapshots__/emitter-ts/package.json
@@ -27,7 +27,7 @@
   "scripts": {
     "build": "tsc",
     "watch": "tsc --watch",
-    "test": "node --test ./dist/test/",
+    "test": "node --test",
     "lint": "eslint src/ test/ --report-unused-disable-directives --max-warnings=0",
     "lint:fix": "eslint . --report-unused-disable-directives --fix",
     "format": "prettier .  --write",

diff --git a/packages/compiler/templates/__snapshots__/library-ts/.eslintrc.yml b/packages/compiler/templates/__snapshots__/library-ts/.eslintrc.yml
diff --git a/packages/compiler/templates/__snapshots__/library-ts/eslint.config.js b/packages/compiler/templates/__snapshots__/library-ts/eslint.config.js
@@ -0,0 +1,11 @@
+// @ts-check
+import eslint from "@eslint/js";
+import tsEslint from "typescript-eslint";
+
+export default tsEslint.config(
+  {
+    ignores: ["**/dist/**/*", "**/.temp/**/*"],
+  },
+  eslint.configs.recommended,
+  ...tsEslint.configs.recommended
+);
diff --git a/packages/compiler/templates/__snapshots__/library-ts/package.json b/packages/compiler/templates/__snapshots__/library-ts/package.json
@@ -30,7 +30,7 @@
     "build": "tsc && npm run build:tsp",
     "watch": "tsc --watch",
     "build:tsp": "tsp compile . --warn-as-error --import @typespec/library-linter --no-emit",
-    "test": "node --test ./dist/test/",
+    "test": "node --test",
     "lint": "eslint src/ test/ --report-unused-disable-directives --max-warnings=0",
     "lint:fix": "eslint . --report-unused-disable-directives --fix",
     "format": "prettier .  --write",

diff --git a/packages/compiler/templates/emitter-ts/package.json b/packages/compiler/templates/emitter-ts/package.json
@@ -27,7 +27,7 @@
   "scripts": {
     "build": "tsc",
     "watch": "tsc --watch",
-    "test": "node --test ./dist/test/",
+    "test": "node --test",
     "lint": "eslint src/ test/ --report-unused-disable-directives --max-warnings=0",
     "lint:fix": "eslint . --report-unused-disable-directives --fix",
     "format": "prettier .  --write",

diff --git a/packages/compiler/templates/library-ts/package.json b/packages/compiler/templates/library-ts/package.json
@@ -30,7 +30,7 @@
     "build": "tsc && npm run build:tsp",
     "watch": "tsc --watch",
     "build:tsp": "tsp compile . --warn-as-error --import @typespec/library-linter --no-emit",
-    "test": "node --test ./dist/test/",
+    "test": "node --test",
     "lint": "eslint src/ test/ --report-unused-disable-directives --max-warnings=0",
     "lint:fix": "eslint . --report-unused-disable-directives --fix",
     "format": "prettier .  --write",

diff --git a/packages/website/versioned_docs/version-latest/extending-typespec/basics.md b/packages/website/versioned_docs/version-latest/extending-typespec/basics.md
@@ -154,7 +154,7 @@ Alternatively, you can add these as scripts in your `package.json` to make them
     "clean": "rimraf ./dist ./temp",
     "build": "tsc -p .",
     "watch": "tsc -p . --watch",
-    "test": "node --test ./dist/test"
+    "test": "node --test ./dist/test/**/*.test.js",
   }
 ```