Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type-fest user test #129

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

voxpelli
Copy link
Contributor

In the type-fest type library there are a lot of complex usages of types and as such it often finds edge cases not seen elsewhere.

I have tried to have a canary test there and will have again when this gets merged: sindresorhus/type-fest#785

But even when running that frequently against nightlies it can be hard to pinpoint what it was that caused something to break, as seen here: sindresorhus/type-fest#784

I personally would find it great if type-fest could be tested here, especially so as its relied upon by many well-used module, resulting in +151 million weekly downloads from npm.

That way we can more early discover if there's an incompatibility and aid in helping out on solving it.

/ Pelle, co-maintainer of type-fest

Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though I really suspect that type-fest is already a part of the topXYZ test suite, which tests the top TS repos.

@jakebailey jakebailey merged commit ad37c36 into microsoft:main Jan 4, 2024
2 checks passed
@voxpelli voxpelli deleted the type-fest-user-test branch January 5, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants