This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Add missing dir to the no-console
#889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We noticed this was missing, allowing workarounds. I know this repo is in hiatus now, but even if you do not merge, it could be useful for people stumbling over this wondering why this does not trigger. We are actually going to override the rule by removing the list of methods, disallowing all `console` methods (and that would be my preferred option for the recommended ruleset, even).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
We noticed this was missing, allowing workarounds. I know this repo is in hiatus now, but even if you do not merge, it could be useful for people stumbling over this wondering why this does not trigger. We are actually going to override the rule by removing the list of methods, disallowing all
consolemethods (and that would be my preferred option for the recommended ruleset, even).I can add tests and docs as needed, if you happen to want to merge this :)