This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Fixed whitespace issues in tslint-warnings.csv #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤔 Hmm, I'm now wondering if the path to the rules directory was actually correct as |
I've reverted that change and the SDL report is still generated correctly when I run |
JoshuaKGoldberg
approved these changes
Dec 30, 2018
apawast
pushed a commit
to lupine86/tslint-microsoft-contrib
that referenced
this pull request
Feb 26, 2019
* Rules directory was wrong. * Only the first new line was being replaced with a space. Now they all are. * Added trailing spaces after full stops in the description. * Used string concatenation in the description to get rid of excess whitespace. * Regenerated the SDL report. * Reverted rules directory change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
New feature, bugfix, or enhancementIncludes testsDocumentation updateOverview of change:
There were a couple of things contributing to the odd whitespace:
react-a11y-role-supports-aria-propswas using string concatenation in the description, but didn't have trailing spaces at the end of each string.react-a11y-rolewas using a template literal. with a new line and indentation in the middle.In addition to this, the rules directory used by the SDL report generator was wrong. It was pointing to
dist/build, but the rules are indist/src, so if you regenerated the SDL report, it deleted all of the lines for the rules in this package.