Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

convert no-constant-condition rule to use walk function #704

Merged
merged 1 commit into from
Dec 28, 2018
Merged

convert no-constant-condition rule to use walk function #704

merged 1 commit into from
Dec 28, 2018

Conversation

drexler
Copy link
Contributor

@drexler drexler commented Dec 28, 2018

PR checklist

Overview of change:

Converts no-constant-condition rule to use walk function

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Dec 28, 2018
View reviewed changes
Copy link

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💖

This is great progress @drexler - thanks for these!

src/noConstantConditionRule.ts Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg merged commit 95a9ec9 into microsoft:master Dec 28, 2018
@drexler drexler deleted the convert-constant-condition-rule branch December 29, 2018 17:16
@IllusionMH IllusionMH added this to the 6.1.0-beta milestone Feb 19, 2019
apawast pushed a commit to lupine86/tslint-microsoft-contrib that referenced this pull request Feb 26, 2019
@drexler @apawast
convert no-constant-condition rule to use walk function (microsoft#704)
cc7435f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1.0-beta
Development

Successfully merging this pull request may close these issues.
3 participants
@drexler @JoshuaKGoldberg @IllusionMH