Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

convert chai-vague-errors rule to use walk function #690

Merged

Conversation

drexler
Copy link
Contributor

@drexler drexler commented Dec 20, 2018

PR checklist

Overview of change:

Converts the chai-vague-errors rule to use the walk function

@drexler
Copy link
Contributor Author

drexler commented Dec 21, 2018

I'll rebase this PR once #686 is approved & merged.

@IllusionMH IllusionMH added the PR: Waiting for Reviewer A repository maintainer should take a look at the pull request soon! label Dec 23, 2018
Copy link

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also great, thanks @drexler!

@JoshuaKGoldberg JoshuaKGoldberg merged commit f837141 into microsoft:master Dec 26, 2018
@drexler drexler deleted the convert-chai-vague-errors-rule branch December 26, 2018 17:59
@IllusionMH IllusionMH added this to the 6.1.0-beta milestone Feb 19, 2019
apawast pushed a commit to lupine86/tslint-microsoft-contrib that referenced this pull request Feb 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: Waiting for Reviewer A repository maintainer should take a look at the pull request soon!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants