Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

node.getWidth() in no-backbone-get-set-outside-model #663

Merged
merged 1 commit into from
Dec 13, 2018

Conversation

JoshuaKGoldberg
Copy link

😄

PR checklist

Overview of change:

Used proper end lengths of lint warnings in no-backbone-get-set-outside-model.

Copy link
Contributor

@IllusionMH IllusionMH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are no more usages of end instead of width, however I've found typo - widget 😃

@JoshuaKGoldberg
Copy link
Author

....and it looks like I've lost merge permissions for the repository. Even more fun! I've reached out to @HamletDRC to see if we can get those back via the Microsoft OSS folks.

@JoshuaKGoldberg JoshuaKGoldberg merged commit cbb2ba2 into master Dec 13, 2018
@JoshuaKGoldberg JoshuaKGoldberg deleted the no-backbone-get-set-outside-model-amuse branch December 14, 2018 16:46
@IllusionMH IllusionMH added this to the 6.1.0-beta milestone Feb 19, 2019
apawast pushed a commit to lupine86/tslint-microsoft-contrib that referenced this pull request Feb 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-backbone-get-set-outside-model has obscenely long rule warnings
2 participants