This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Make export-name RegExp more strict #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IllusionMH
force-pushed
the
strict-export-name-regexp-632
branch
from
d014bc5 to
74bb09d
Compare
IllusionMH
commented
Nov 5, 2018
IllusionMH
commented
Nov 5, 2018
IllusionMH
force-pushed
the
strict-export-name-regexp-632
branch
from
74bb09d to
00809af
Compare
JoshuaKGoldberg
approved these changes
Nov 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
feature,bugfix,or enhancementOverview of change:
This PR requires exported class name strictly match start of file name followed by
.and atleast 1 more extension character.Will rebase/cleanup after #641 merged
Is there anything you'd like reviewers to focus on?
Ignore
Ruleclass name from checks in this repo, because all rule files exports justRulewhich is violation.I think nice to have in
6.0since it is more strict now and may be breaking for those who uses it fromrecommended_ruleset.js