This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Disallow current/parent folders inside module path #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whoohoo! |
JoshuaKGoldberg
approved these changes
Nov 3, 2018
|
Thanks! |
|
Ha, more evidence that the bases tests are the way to go for easier contributing! 😉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #624
This PR disallows references to current and parent directory (e.g.
common/../other-folder/App).This check doesn't depend on
allow-siblingsargument, and new error will be shown only if path passes checks for relative or parent references at the beginning.I've removed Mocha tests for
no-relative-importsrule, so this is first rule that fully migrated to TSLint format tests.