Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Enabled type checked rules when linting #604

Merged
merged 1 commit into from
Oct 29, 2018
Merged

Enabled type checked rules when linting #604

merged 1 commit into from
Oct 29, 2018

Conversation

reduckted
Copy link
Contributor

@reduckted reduckted commented Oct 29, 2018 •
edited
Loading

Fixes #567.

I've disabled prefer-readonly (see #602) and no-use-before-declare (see #603) because they caused lint failures.

@reduckted reduckted mentioned this pull request Oct 29, 2018
Closed
17 tasks
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 29, 2018
View reviewed changes
Copy link

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ✨ this will open up a bunch of nice lint rule possibilities.

@JoshuaKGoldberg JoshuaKGoldberg merged commit c94e29e into microsoft:master Oct 29, 2018
@JoshuaKGoldberg JoshuaKGoldberg added this to the 6.0.0-beta0 milestone Nov 6, 2018
@reduckted reduckted deleted the 567-type-checking branch December 30, 2018 11:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.0-beta
Development

Successfully merging this pull request may close these issues.
2 participants
@reduckted @JoshuaKGoldberg