Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Fix #276: Add check for title attribute for images. #540

Merged

Conversation

afifsohaili
Copy link
Contributor

@afifsohaili afifsohaili commented Oct 10, 2018

  • All images must have alt attribute.
  • If the image is meant to be ignored, have a presentation role with an
    empty alt attribute.
  • If the image has an empty alt attribute but has a title attribute with
    a value, it fails.

Fixes #276.

* All images must have alt attribute.
* If the image is meant to be ignored, have a presentation role with an
empty alt attribute.
* If the image has an empty alt attribute but has a title attribute with
a value, it fails.
@msftclas
Copy link

msftclas commented Oct 10, 2018

CLA assistant check
All CLA requirements met.

Copy link

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @afifsohaili! 🔥

@JoshuaKGoldberg JoshuaKGoldberg merged commit ff9b079 into microsoft:master Oct 14, 2018
@afifsohaili afifsohaili deleted the img-alt-ignored-image-support branch October 16, 2018 23:03
@JoshuaKGoldberg JoshuaKGoldberg added this to the 6.0.0 milestone Nov 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants