Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Reasonable and intuitive line counting (proposed fix for #468) #469

Merged
merged 4 commits into from
Jul 25, 2018
Merged

Reasonable and intuitive line counting (proposed fix for #468) #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
219cdb6
Proposed fix for issue #468
makotom Jul 25, 2018
7279c01
Revision of a test script responding to a fix of #468
makotom Jul 25, 2018
f1e963f
Avoid using tsutils v2.29.0, which breaks tests
makotom Jul 25, 2018
c3473db
Revert "Avoid using tsutils v2.29.0, which breaks tests"
makotom Jul 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/maxFuncBodyLengthRule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ class MaxFunctionBodyLengthRuleWalker extends Lint.RuleWalker {
const sourceFile: ts.SourceFile = this.getSourceFile();
const startLine: number = sourceFile.getLineAndCharacterOfPosition(node.body.pos).line;
const endLine: number = sourceFile.getLineAndCharacterOfPosition(node.body.end).line;
return endLine - startLine;
return endLine - startLine + 1;
}

private calcBodyCommentLength(node: ts.FunctionLikeDeclaration) {
Expand Down
Loading