Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Fix the new rule snippet to not create an immediately broken file #348

Closed
wants to merge 1 commit into from
Closed

Fix the new rule snippet to not create an immediately broken file #348

wants to merge 1 commit into from

Conversation

ChrisMBarr
Copy link
Contributor

I wanted to create a new rule for this project, so I followed the instructions and ran

grunt create-rule --rule-name=my-new-rule

which created a broken rule file that I had to figure out why it was broken before I could start developing. This PR should fix the incorrect path to tslint and add the missing required properties to the metadata class member.

Perhaps some tests should be added for this project that creates a rule with this command and ensures that it can be compiled?

@msftclas
Copy link

@ChrisMBarr, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@HamletDRC
Copy link
Member

Thanks for noticing and fixing!

@HamletDRC HamletDRC modified the milestone: 4.0.2 May 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants