Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

function-name rule - add support for linting protected methods #308

Closed
wants to merge 2 commits into from
Closed

function-name rule - add support for linting protected methods #308

wants to merge 2 commits into from

Conversation

netroy
Copy link
Contributor

@netroy netroy commented Oct 31, 2016

this adds support for protected class methods on classes for the function-name rule.

also, removed the duplicate regexp across public, private & protected methods.

@msftclas
Copy link

Hi @netroy, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Aditya Yadav). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

@netroy, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@HamletDRC HamletDRC added this to the 2.0.14 milestone Nov 1, 2016
@HamletDRC HamletDRC changed the title Add support for linting Protected methods function-name rule - add support for linting protected methods Nov 1, 2016
HamletDRC pushed a commit that referenced this pull request Nov 1, 2016
merges #308

default privateMethodRegex to methodRegex

add support for linting protected methods
@HamletDRC
Copy link
Member

Thanks! I updated the readme as well.

@HamletDRC HamletDRC closed this Nov 1, 2016
@netroy netroy deleted the protected-methods branch November 1, 2016 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants