Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Remove deprecated no-duplicate-key rule #300

Closed
wants to merge 1 commit into from

Conversation

connor4312
Copy link
Member

@connor4312 connor4312 commented Oct 22, 2016

This has been deprecated in tslint's upcoming 4.x (palantir/tslint#885) as it's functionality which is covered by the compiler. For that reason, removing the rule prior to release should have no negative effects and is one less thing to change down the line 😄

@msftclas
Copy link

Hi @connor4312, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Connor Peet). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@HamletDRC
Copy link
Member

@connor4312 do you know what version of TypeScript made this change? We support 1.5 forward. I am trying to figure out if 1.5, 1.6, or 1.7 needs this rule.

@HamletDRC
Copy link
Member

@connor4312 I just tested this and 1.5.3 will emit a compiler error for duplicate keys. I'll merge this in.

Thanks for taking the time to send a PR, I really appreciate the effort.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants