Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Add react-a11y-proptypes rule. #241

Closed
wants to merge 3 commits into from

Conversation

t-ligu
Copy link
Contributor

@t-ligu t-ligu commented Sep 12, 2016

No description provided.

@msftclas
Copy link

Hi @t-ligu, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Liubin Guo). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@t-ligu
Copy link
Contributor Author

t-ligu commented Sep 12, 2016

@HamletDRC I added react-a11y-proptypes rule.

public visitJsxAttribute(node: ts.JsxAttribute): void {
const propName: string = getPropName(node).toLowerCase();

// if there is not a aria-* attribute, don't check it.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no aria-* attribute, skip it.

@HamletDRC HamletDRC closed this in 39bad10 Sep 15, 2016
@HamletDRC HamletDRC modified the milestone: None Oct 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants