Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Stop including library-specific rules in the recommended ruleset #716

Closed
JoshuaKGoldberg opened this issue Dec 29, 2018 · 5 comments · Fixed by #809
Closed

Stop including library-specific rules in the recommended ruleset #716

JoshuaKGoldberg opened this issue Dec 29, 2018 · 5 comments · Fixed by #809
Labels
Domain: Tooling Repository tasks around improving source tooling. Status: In Discussion Please continue discussing the proposed change before sending a pull request. Type: Breaking Change
Milestone

Comments

@JoshuaKGoldberg
Copy link

Spinning off the discussion in #708: enabling the Backbone-related rules in the recommended ruleset is probably just a slight performance tick for the vast majority of users. Can we remove them by default? How about, say, the jQuery rules?

IMO the mocha/chai/etc. test rules should stay in, since that's the general shape of testing APIs in JavaScript test frameworks these days.

@JoshuaKGoldberg JoshuaKGoldberg added Status: In Discussion Please continue discussing the proposed change before sending a pull request. Type: Breaking Change Domain: Tooling Repository tasks around improving source tooling. labels Dec 29, 2018
@IllusionMH
Copy link
Contributor

May be makes sense to provide several configurations (IIRC it is possible, at least TSLint has all and recommended)?
So migration to next version will require only simple update of configuration to extend to include framework/lib specific checks.

@VincentLanglet
Copy link

VincentLanglet commented Jan 4, 2019

Indeed by creating multiple configuration you don't need for breaking change.

v6 can have tslint-microsoft-config, tslint-microsoft-config:all (doing the same) and tslint-microsoft-config:recommended, and tslint-microsoft-config can be deprecated and removed in v7.

You can also resolve this issue the same way by removing them from tslint-microsoft-config:recommended.

@VincentLanglet
Copy link

@JoshuaKGoldberg I think the PR does not solve this issue.
For example the backbone related rule is still active.
https://github.com/Microsoft/tslint-microsoft-contrib/pull/809/files#diff-3833edc218170b17d9bac70044d7f313

@JoshuaKGoldberg
Copy link
Author

Hmm, perhaps this means we should have a latest and all ruleset split...

@VincentLanglet
Copy link

Yes, I agree.

  • recommended is a subset of all rules, minor version doesn't add breaking changes.
  • latest is the recommended rules for the next major version, but still a subset of all rules.
  • all is all.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Domain: Tooling Repository tasks around improving source tooling. Status: In Discussion Please continue discussing the proposed change before sending a pull request. Type: Breaking Change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants