This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Remove [email protected] rules from the recommended ruleset (before the next release) #697
Comments
JoshuaKGoldberg
added
the
Domain: Tooling
2 tasks
IllusionMH
pushed a commit
that referenced
this issue
Jan 11, 2019
* Removed [email protected] rules from the recommended ruleset This is a breaking change, so we don't want it to come in unplanned. Fixes #697 * Added missing JSDoc see * Simplified filtering code and moved to just generate-recommendations.js * Undid tslint-warnings.csv changes * Simplified getAllRules().forEach with ruleName * No, the names are in dash-case * Also removed comment-type recommendation
apawast
pushed a commit
to lupine86/tslint-microsoft-contrib
that referenced
this issue
Feb 26, 2019
* Removed [email protected] rules from the recommended ruleset This is a breaking change, so we don't want it to come in unplanned. Fixes microsoft#697 * Added missing JSDoc see * Simplified filtering code and moved to just generate-recommendations.js * Undid tslint-warnings.csv changes * Simplified getAllRules().forEach with ruleName * No, the names are in dash-case * Also removed comment-type recommendation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Following #686 - rules from [email protected] are now in the recommended ruleset. That'd be a breaking change and IMO we shouldn't release a minor version before taking them back out.
This is a precursor to, and the opposite of #694 - that one is for adding them back in as a breaking change.
The text was updated successfully, but these errors were encountered: