Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Mark no-unnecessary-class as deprecated #504

Closed
JoshuaKGoldberg opened this issue Oct 2, 2018 · 3 comments
Closed

Mark no-unnecessary-class as deprecated #504

JoshuaKGoldberg opened this issue Oct 2, 2018 · 3 comments
Labels
Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. Status: Accepting PRs
Milestone
None

Comments

@JoshuaKGoldberg
Copy link

TSLint core now has its own no-unnecessary-class with more features. Hooray!

See no-duplicate-case-rule for an example of a rule that's already deprecated.
@JoshuaKGoldberg JoshuaKGoldberg added Status: Accepting PRs Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. Hacktoberfest labels Oct 2, 2018
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Oct 2, 2018
Closed
@fortrieb
Copy link
Contributor

fortrieb commented Oct 2, 2018

Hi, i will take this issue if no one is already working on it.

fortrieb added a commit to fortrieb/tslint-microsoft-contrib that referenced this issue Oct 2, 2018
@fortrieb
Mark no-unnecessary-class as deprecated
dbb2695 
Fix microsoft#504
@fortrieb fortrieb mentioned this issue Oct 2, 2018
Merged
JoshuaKGoldberg pushed a commit that referenced this issue Oct 2, 2018
@fortrieb
Fix #504: Mark no-unnecessary-class as deprecated (#506)
87a234a 
* Mark no-unnecessary-class as deprecated

Fix #504

* fix typo on group property
@IllusionMH
Copy link
Contributor

I've found this issue linked to other opened and I have a question:
Why no-unnecessary-class was marked as deprecated here?
This rule is part of core TSLint rules, and not part of this repo.

And no-unnecessary-class(TSLint core) should be used instead of no-stateless-class(this repo) which is already marked as deprecated and has proper warning about it (same as mentioned no-duplicate-case-rule).

@JoshuaKGoldberg
Copy link
Author

@IllusionMH good catch. I'll go through and fix these up :) thanks.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Oct 25, 2018
Closed
@JoshuaKGoldberg JoshuaKGoldberg added this to the None milestone Nov 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. Status: Accepting PRs
Projects
None yet
Milestone
None
Development

No branches or pull requests
3 participants
@IllusionMH @JoshuaKGoldberg @fortrieb