#338 Bug: no-http-string's description says start, but it checks for any

closes #338
microsoft · Feb 2, 2017 · cc2d7f4 · cc2d7f4
1 parent be8c298
commit cc2d7f4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/noHttpStringRule.ts b/src/noHttpStringRule.ts
@@ -40,7 +40,7 @@ class NoHttpStringWalker extends ErrorTolerantWalker {
     protected visitStringLiteral(node: ts.StringLiteral): void {
         const stringText : string = (<ts.LiteralExpression>node).text;
         // tslint:disable no-http-string
-        if (stringText.indexOf('http:') !== -1) {
+        if (stringText.indexOf('http:') === 0) {
             if (!this.isSuppressed(stringText)) {
                 const failureString = Rule.FAILURE_STRING + '\'' + stringText + '\'';
                 const failure = this.createFailure(node.getStart(), node.getWidth(), failureString);

diff --git a/src/tests/NoHttpStringRuleTests.ts b/src/tests/NoHttpStringRuleTests.ts
@@ -36,6 +36,11 @@ describe('noHttpStringRule', (): void => {
         TestHelper.assertViolations(ruleName, inputScript, []);
     });
 
+    it('should allow http in middle of string', (): void => {
+        const inputScript: string = 'var x = \'The prototcol may be http:// or https://\'';
+        TestHelper.assertViolations(ruleName, inputScript, []);
+    });
+
     it('should allow https strings in default values', (): void => {
         const inputScript: string = 'function f(x : string = \'https://www.microsoft.com\') {}';
         TestHelper.assertViolations(ruleName, inputScript, []);