Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Commit

Permalink
Finished removing unecessary (placating missing-jsdoc) JSDocs
Browse files Browse the repository at this point in the history
Fixes #557
  • Loading branch information
Josh Goldberg committed Oct 15, 2018
1 parent dea2835 commit 698f0c0
Show file tree
Hide file tree
Showing 163 changed files with 3 additions and 489 deletions.
1 change: 0 additions & 1 deletion recommended_ruleset.js
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ module.exports = {
"max-line-length": [true, 140],
"member-access": true,
"member-ordering": [true, { "order": "fields-first" }],
"missing-jsdoc": true,
"mocha-unneeded-done": true,
"new-parens": true,
"newline-per-chained-call": true,
Expand Down
3 changes: 0 additions & 3 deletions src/chaiPreferContainsToIndexOfRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ import {ExtendedMetadata} from './utils/ExtendedMetadata';

const FAILURE_STRING: string = 'Found chai call with indexOf that can be converted to .contain assertion: ';

/**
* Implementation of the chai-prefer-contains-to-index-of rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/chaiVagueErrorsRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ const FAILURE_STRING_COMPARE_TRUE: string = BASE_ERROR + 'Move the strict equali
const FAILURE_STRING_COMPARE_FALSE: string = BASE_ERROR + 'Move the strict inequality comparison from the expect ' +
'call into the assertion value. ';

/**
* Implementation of the chai-vague-errors rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
4 changes: 1 addition & 3 deletions src/exportNameRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@ import {AstUtils} from './utils/AstUtils';
import {ExtendedMetadata} from './utils/ExtendedMetadata';

export const OPTION_IGNORE_CASE: string = 'ignore-case';
/**
* Implementation of the export-name rule.
*/

export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/functionNameRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,6 @@ interface Options {
readonly validateStatics: string;
}

/**
* Implementation of the function-name rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/importNameRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ import {ErrorTolerantWalker} from './utils/ErrorTolerantWalker';
import {Utils} from './utils/Utils';
import {ExtendedMetadata} from './utils/ExtendedMetadata';

/**
* Implementation of the import-name rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/insecureRandomRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ const MATH_FAIL_STRING: string = 'Math.random produces insecure random numbers.
const NODE_FAIL_STRING: string = 'crypto.pseudoRandomBytes produces insecure random numbers. ' +
'Use crypto.randomBytes() instead';

/**
* Implementation of the insecure-random rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/jqueryDeferredMustCompleteRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ import {AstUtils} from './utils/AstUtils';
import {Utils} from './utils/Utils';
import {ExtendedMetadata} from './utils/ExtendedMetadata';

/**
* Implementation of the jquery-deferred-must-complete rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/maxFuncBodyLengthRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ import {Utils} from './utils/Utils';
import {ExtendedMetadata} from './utils/ExtendedMetadata';
import {forEachTokenWithTrivia} from 'tsutils';

/**
* Implementation of the max-func-body-length rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
5 changes: 1 addition & 4 deletions src/missingJsdocRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ import * as Lint from 'tslint';
import {ErrorTolerantWalker} from './utils/ErrorTolerantWalker';
import {ExtendedMetadata} from './utils/ExtendedMetadata';

/**
* Implementation of the missing-jsdoc rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand All @@ -16,7 +13,7 @@ export class Rule extends Lint.Rules.AbstractRule {
options: null,
optionsDescription: '',
typescriptOnly: true,
issueClass: 'Non-SDL',
issueClass: 'Ignored',
issueType: 'Warning',
severity: 'Low',
level: 'Opportunity for Excellence',
Expand Down
3 changes: 0 additions & 3 deletions src/missingOptionalAnnotationRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ import * as Lint from 'tslint';
import {ErrorTolerantWalker} from './utils/ErrorTolerantWalker';
import {ExtendedMetadata} from './utils/ExtendedMetadata';

/**
* Implementation of the missing-optional-annotation rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/mochaAvoidOnlyRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ import {ErrorTolerantWalker} from './utils/ErrorTolerantWalker';
import {ExtendedMetadata} from './utils/ExtendedMetadata';
import {MochaUtils} from './utils/MochaUtils';

/**
* Implementation of the mocha-avoid-only rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/mochaNoSideEffectCodeRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ import {Utils} from './utils/Utils';

const FAILURE_STRING: string = 'Mocha test contains dangerous variable initialization. Move to before()/beforeEach(): ';

/**
* Implementation of the mocha-no-side-effect-code rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/mochaUnneededDoneRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ import {MochaUtils} from './utils/MochaUtils';

const FAILURE_STRING: string = 'Unneeded Mocha Done. Parameter can be safely removed: ';

/**
* Implementation of the mocha-unneeded-done rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
6 changes: 0 additions & 6 deletions src/noBackboneGetSetOutsideModelRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,6 @@ import {ErrorTolerantWalker} from './utils/ErrorTolerantWalker';
import {AstUtils} from './utils/AstUtils';
import {ExtendedMetadata} from './utils/ExtendedMetadata';

/**
* Implementation of the no-backbone-get-set-outside-model rule.
*
* Currently only makes sure that get and set Backbone methods are called
* on the this reference.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/noBannedTermsRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ import * as Lint from 'tslint';
import {ExtendedMetadata} from './utils/ExtendedMetadata';
import {BannedTermWalker} from './utils/BannedTermWalker';

/**
* Implementation of the no-banned-terms rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/noConstantConditionRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ import {AstUtils} from './utils/AstUtils';
import {ErrorTolerantWalker} from './utils/ErrorTolerantWalker';
import {ExtendedMetadata} from './utils/ExtendedMetadata';

/**
* Implementation of the no-constant-condition rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/noControlRegexRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ import * as Lint from 'tslint';
import {ErrorTolerantWalker} from './utils/ErrorTolerantWalker';
import {ExtendedMetadata} from './utils/ExtendedMetadata';

/**
* Implementation of the no-control-regex rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/noCookiesRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ import * as Lint from 'tslint';
import {ErrorTolerantWalker} from './utils/ErrorTolerantWalker';
import {ExtendedMetadata} from './utils/ExtendedMetadata';

/**
* Implementation of the no-cookies-rule rule.
*/
export class Rule extends Lint.Rules.TypedRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/noDeleteExpressionRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ import * as Lint from 'tslint';
import {ErrorTolerantWalker} from './utils/ErrorTolerantWalker';
import {ExtendedMetadata} from './utils/ExtendedMetadata';

/**
* Implementation of the no-delete-expression rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/noDisableAutoSanitizationRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ import {ErrorTolerantWalker} from './utils/ErrorTolerantWalker';
import {AstUtils} from './utils/AstUtils';
import {ExtendedMetadata} from './utils/ExtendedMetadata';

/**
* Implementation of the no-disable-auto-sanitization rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/noDocumentDomainRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ import * as Lint from 'tslint';
import {ErrorTolerantWalker} from './utils/ErrorTolerantWalker';
import {ExtendedMetadata} from './utils/ExtendedMetadata';

/**
* Implementation of the no-document-domain rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/noDocumentWriteRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ import {ErrorTolerantWalker} from './utils/ErrorTolerantWalker';
import {AstUtils} from './utils/AstUtils';
import {ExtendedMetadata} from './utils/ExtendedMetadata';

/**
* Implementation of the no-document-write rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/noDuplicateCaseRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ import * as Lint from 'tslint';
import {ErrorTolerantWalker} from './utils/ErrorTolerantWalker';
import {ExtendedMetadata} from './utils/ExtendedMetadata';

/**
* Implementation of the no-duplicate-case rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/noDuplicateParameterNamesRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ import * as Lint from 'tslint';
import {ErrorTolerantWalker} from './utils/ErrorTolerantWalker';
import {ExtendedMetadata} from './utils/ExtendedMetadata';

/**
* Implementation of the no-duplicate-parameter-names rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/noEmptyInterfacesRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ import * as Lint from 'tslint';
import {ErrorTolerantWalker} from './utils/ErrorTolerantWalker';
import {ExtendedMetadata} from './utils/ExtendedMetadata';

/**
* Implementation of the no-empty-interfaces rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/noEmptyLineAfterOpeningBraceRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ import {ErrorTolerantWalker} from './utils/ErrorTolerantWalker';
import {ExtendedMetadata} from './utils/ExtendedMetadata';
import {forEachTokenWithTrivia} from 'tsutils';

/**
* Implementation of the no-empty-line-after-opening-brace rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/noExecScriptRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ import {ExtendedMetadata} from './utils/ExtendedMetadata';

import {AstUtils} from './utils/AstUtils';

/**
* Implementation of the no-exec-script rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/noForInRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ import * as Lint from 'tslint';
import {ErrorTolerantWalker} from './utils/ErrorTolerantWalker';
import {ExtendedMetadata} from './utils/ExtendedMetadata';

/**
* Implementation of the no-for-in rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/noFunctionConstructorWithStringArgsRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ import {ErrorTolerantWalker} from './utils/ErrorTolerantWalker';
import {AstUtils} from './utils/AstUtils';
import {ExtendedMetadata} from './utils/ExtendedMetadata';

/**
* Implementation of the no-function-constructor-with-string-args rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/noFunctionExpressionRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ import { AstUtils } from './utils/AstUtils';
import {ErrorTolerantWalker} from './utils/ErrorTolerantWalker';
import {ExtendedMetadata} from './utils/ExtendedMetadata';

/**
* Implementation of the no-function-expression rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/noHttpStringRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ import {ErrorTolerantWalker} from './utils/ErrorTolerantWalker';
import {Utils} from './utils/Utils';
import {ExtendedMetadata} from './utils/ExtendedMetadata';

/**
* Implementation of the no-http-string rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/noIncrementDecrementRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ import * as Lint from 'tslint';
import {ErrorTolerantWalker} from './utils/ErrorTolerantWalker';
import {ExtendedMetadata} from './utils/ExtendedMetadata';

/**
* Implementation of the no-increment-decrement rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/noInnerHtmlRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ const FAILURE_INNER: string = 'Writing a string to the innerHTML property is ins
const FAILURE_OUTER: string = 'Writing a string to the outerHTML property is insecure: ';
const FAILURE_HTML_LIB: string = 'Using the html() function to write a string to innerHTML is insecure: ';

/**
* Implementation of the no-inner-html rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/noInvalidRegexpRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ import * as Lint from 'tslint';
import {ErrorTolerantWalker} from './utils/ErrorTolerantWalker';
import {ExtendedMetadata} from './utils/ExtendedMetadata';

/**
* Implementation of the no-invalid-regexp rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/noJqueryRawElementsRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ import {ExtendedMetadata} from './utils/ExtendedMetadata';
const FAILURE_STRING_MANIPULATION: string = 'Replace HTML string manipulation with jQuery API: ';
const FAILURE_STRING_COMPLEX: string = 'Replace complex HTML strings with jQuery API: ';

/**
* Implementation of the no-jquery-raw-elements rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/noMissingVisibilityModifiersRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ import {ErrorTolerantWalker} from './utils/ErrorTolerantWalker';
import {AstUtils} from './utils/AstUtils';
import {ExtendedMetadata} from './utils/ExtendedMetadata';

/**
* Implementation of the mo-missing-visibility-modifiers rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
3 changes: 0 additions & 3 deletions src/noMultilineStringRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ import * as Lint from 'tslint';
import {ErrorTolerantWalker} from './utils/ErrorTolerantWalker';
import {ExtendedMetadata} from './utils/ExtendedMetadata';

/**
* Implementation of the no-multiline-string rule.
*/
export class Rule extends Lint.Rules.AbstractRule {

public static metadata: ExtendedMetadata = {
Expand Down
Loading

0 comments on commit 698f0c0

Please sign in to comment.