update private class element helpers #146

mkubilayk · 2021-03-23T16:54:58Z

A companion to microsoft/TypeScript#42458 - this PR updates __classPrivateFieldGet and __classPrivateFieldSet helpers to support private instance methods and accessors, and private static elements.

cc: @rbuckton

rbuckton · 2021-03-25T01:43:12Z

@DanielRosenwasser we will need to ship a new tslib to support microsoft/TypeScript#42458

rbuckton · 2021-04-03T20:48:31Z

@DanielRosenwasser can you publish a new tslib?

1440: fix: update dependency tslib to v2.3.1 (master) r=renovate[bot] a=renovate[bot] [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [tslib](https://www.typescriptlang.org/) ([source](https://togithub.com/Microsoft/tslib)) | [`2.1.0` -> `2.3.1`](https://renovatebot.com/diffs/npm/tslib/2.1.0/2.3.1) | [![age](https://badges.renovateapi.com/packages/npm/tslib/2.3.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/tslib/2.3.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/tslib/2.3.1/compatibility-slim/2.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/tslib/2.3.1/confidence-slim/2.1.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Microsoft/tslib</summary> ### [`v2.3.1`](https://togithub.com/Microsoft/tslib/releases/2.3.1) [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.3.0...2.3.1) This release updates the `__spreadArray` helper for TypeScript 4.4 to correctly operate on collections that are not "concat-spreadable" such as the DOM's `NodeList`s and `HTMLCollection`s. ### [`v2.3.0`](https://togithub.com/Microsoft/tslib/releases/2.3.0) [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.2.0...2.3.0) This release updates tslib to use TypeScript 4.4's upcoming `__spreadArray` helper which correctly preserves sparse array inputs (e.g. arrays containing "missing" elements like `[1, 2, , 4]`). This new version of `__spreadArray` is backwards-compatible and is often also faster. See [https://github.com/microsoft/tslib/pull/151](https://togithub.com/microsoft/tslib/pull/151) for more details. ### [`v2.2.0`](https://togithub.com/Microsoft/tslib/releases/2.2.0) [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.1.0...2.2.0) This release supports TypeScript 4.3's new functionality for ECMAScript private methods and accessors, and private static class members. It does so by expanding the scope of `__classPrivateFieldGet` and `__classPrivateFieldSet`. See [https://github.com/microsoft/tslib/pull/146](https://togithub.com/microsoft/tslib/pull/146) for more details. </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/foosbyte/kicker-trainer). Co-authored-by: Renovate Bot <[email protected]>

This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [tslib](https://www.typescriptlang.org/) ([source](https://togithub.com/Microsoft/tslib)) | [`2.6.2` -> `2.6.3`](https://renovatebot.com/diffs/npm/tslib/1.14.1/2.6.3) | [![age](https://developer.mend.io/api/mc/badges/age/npm/tslib/2.6.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/tslib/2.6.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/tslib/1.14.1/2.6.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/tslib/1.14.1/2.6.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Microsoft/tslib (tslib)</summary> ### [`v2.6.3`](https://togithub.com/microsoft/tslib/releases/tag/v2.6.3) [Compare Source](https://togithub.com/Microsoft/tslib/compare/v2.6.2...v2.6.3) #### What's Changed - 'await using' normative changes by [@rbuckton](https://togithub.com/rbuckton) in [https://github.com/microsoft/tslib/pull/258](https://togithub.com/microsoft/tslib/pull/258) **Full Changelog**: microsoft/tslib@v2.6.2...v2.6.3 ### [`v2.6.2`](https://togithub.com/microsoft/tslib/releases/tag/v2.6.2): tslib 2.6.2 [Compare Source](https://togithub.com/Microsoft/tslib/compare/v2.6.1...v2.6.2) #### What's Changed - Fix path to `exports["module"]["types"]` by [@andrewbranch](https://togithub.com/andrewbranch) in [https://github.com/microsoft/tslib/pull/217](https://togithub.com/microsoft/tslib/pull/217) **Full Changelog**: microsoft/tslib@v2.6.1...v2.6.2 ### [`v2.6.1`](https://togithub.com/microsoft/tslib/releases/tag/v2.6.1): tslib 2.6.1 [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.6.0...v2.6.1) #### What's Changed - Allow functions as values in \__addDisposableResource by [@rbuckton](https://togithub.com/rbuckton) in [https://github.com/microsoft/tslib/pull/215](https://togithub.com/microsoft/tslib/pull/215) - Stop using es6 syntax in the es6 file by [@andrewbranch](https://togithub.com/andrewbranch) in [https://github.com/microsoft/tslib/pull/216](https://togithub.com/microsoft/tslib/pull/216) **Full Changelog**: microsoft/tslib@2.6.0...v2.6.1 ### [`v2.6.0`](https://togithub.com/microsoft/tslib/releases/tag/2.6.0): tslib 2.6.0 [Compare Source](https://togithub.com/Microsoft/tslib/compare/v2.5.3...2.6.0) #### What's Changed - Add helpers for `using` and `await using` by [@rbuckton](https://togithub.com/rbuckton) in [https://github.com/microsoft/tslib/pull/213](https://togithub.com/microsoft/tslib/pull/213) **Full Changelog**: microsoft/tslib@v2.5.3...2.6.0 ### [`v2.5.3`](https://togithub.com/microsoft/tslib/releases/tag/v2.5.3): tslib 2.5.3 [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.5.2...v2.5.3) #### What's Changed - Do not reference tslib.es6.js from package.json exports by [@andrewbranch](https://togithub.com/andrewbranch) in [https://github.com/microsoft/tslib/pull/208](https://togithub.com/microsoft/tslib/pull/208) **Full Changelog**: microsoft/tslib@2.5.2...v2.5.3 ### [`v2.5.2`](https://togithub.com/microsoft/tslib/releases/tag/2.5.2): tslib 2.5.2 [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.5.1...2.5.2) This release [explicitly re-exports helpers](https://togithub.com/microsoft/tslib/pull/204) to work around TypeScript's incomplete symbol resolution for tslib. ### [`v2.5.1`](https://togithub.com/microsoft/tslib/releases/tag/2.5.1): tslib 2.5.1 [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.5.0...2.5.1) This release of tslib provides fixes for two issues. First, [it reverses the order of `init` hooks provided by decorators](https://togithub.com/microsoft/tslib/pull/202) to correctly reflect proposed behavior. Second, it [corrects the `exports` field of tslib's `package.json` and provides accurate declaration files](https://togithub.com/microsoft/tslib/pull/202) so that it may be consumed under the `node16` and `bundler` settings for `moduleResolution.` ### [`v2.5.0`](https://togithub.com/microsoft/tslib/releases/tag/2.5.0): tslib 2.5.0 [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.4.1...2.5.0) #### What's New - Fix asyncDelegator reporting done too early by [@apendua](https://togithub.com/apendua) in [https://github.com/microsoft/tslib/pull/187](https://togithub.com/microsoft/tslib/pull/187) - Add support for TypeScript 5.0's `__esDecorate` and related helpers by [@rbuckton](https://togithub.com/rbuckton) in [https://github.com/microsoft/tslib/pull/193](https://togithub.com/microsoft/tslib/pull/193) **Full Changelog**: microsoft/tslib@2.4.1...2.5.0 ### [`v2.4.1`](https://togithub.com/microsoft/tslib/releases/tag/2.4.1): tslib 2.4.1 [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.4.0...2.4.1) This release contains [fixes for early `return`s and `throw`s invoked on generators](https://togithub.com/microsoft/tslib/pull/186). ### [`v2.4.0`](https://togithub.com/microsoft/tslib/releases/tag/2.4.0): tslib 2.4.0 [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.3.1...2.4.0) This release includes the `__classPrivateFieldIn` helper as well as an update to `__createBinding` to reduce indirection between multiple re-exports. ### [`v2.3.1`](https://togithub.com/microsoft/tslib/releases/tag/2.3.1): tslib 2.3.1 [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.3.0...2.3.1) This release updates the `__spreadArray` helper for TypeScript 4.4 to correctly operate on collections that are not "concat-spreadable" such as the DOM's `NodeList`s and `HTMLCollection`s. ### [`v2.3.0`](https://togithub.com/microsoft/tslib/releases/tag/2.3.0): tslib 2.3.0 [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.2.0...2.3.0) This release updates tslib to use TypeScript 4.4's upcoming `__spreadArray` helper which correctly preserves sparse array inputs (e.g. arrays containing "missing" elements like `[1, 2, , 4]`). This new version of `__spreadArray` is backwards-compatible and is often also faster. See [https://github.com/microsoft/tslib/pull/151](https://togithub.com/microsoft/tslib/pull/151) for more details. ### [`v2.2.0`](https://togithub.com/microsoft/tslib/releases/tag/2.2.0): tslib 2.2.0 [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.1.0...2.2.0) This release supports TypeScript 4.3's new functionality for ECMAScript private methods and accessors, and private static class members. It does so by expanding the scope of `__classPrivateFieldGet` and `__classPrivateFieldSet`. See [https://github.com/microsoft/tslib/pull/146](https://togithub.com/microsoft/tslib/pull/146) for more details. ### [`v2.1.0`](https://togithub.com/microsoft/tslib/releases/tag/2.1.0): tslib 2.1.0 [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.0.3...2.1.0) This release adds a new `__spreadArray` helper which avoids side-effects compared to the now-deprecated `__spreadArrays` and `__spread` helpers. See [https://github.com/microsoft/tslib/pull/133](https://togithub.com/microsoft/tslib/pull/133) for more details. This release also provides a more-specific error message when extending from a type which is not a function and not null. See [https://github.com/microsoft/tslib/pull/138](https://togithub.com/microsoft/tslib/pull/138) for more details. ### [`v2.0.3`](https://togithub.com/microsoft/tslib/releases/tag/2.0.3): Webpack 5 Compatibility - 2.x [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.0.2...2.0.3) Full discussion in the [webpack issue](https://togithub.com/webpack/webpack/issues/11613) ### [`v2.0.2`](https://togithub.com/microsoft/tslib/releases/tag/2.0.2): ES Module Support [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.0.1...2.0.2) This release adds support for using tslib in Node using esmodule imports, further context in [#126](https://togithub.com/Microsoft/tslib/issues/126) and the related issues. ### [`v2.0.1`](https://togithub.com/microsoft/tslib/releases/tag/2.0.1): Minor release for TS 4.0 [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.0.0...2.0.1) 1. Use Object.prototype.hasOwnProperty.call. 2. Skip default when iterating exports in \__importStar. 3. Shorter parameter name in \__exportStar. ### [`v2.0.0`](https://togithub.com/microsoft/tslib/releases/tag/2.0.0): tslib 2.0.0 [Compare Source](https://togithub.com/Microsoft/tslib/compare/v1.14.1...2.0.0) This release changes `__exportStar` and `__importStar` to use `__createBinding` which is incompatible with versions of TypeScript older than 3.9 (i.e. 3.8 and below). </details> --- - [ ] If you want to rebase/retry this PR, check this box  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

update private class element helpers (#2)

6acd349

mkubilayk mentioned this pull request Mar 23, 2021

ES private class elements microsoft/TypeScript#42458

Merged

3 tasks

rbuckton approved these changes Mar 25, 2021

View reviewed changes

rbuckton merged commit 145fdc0 into microsoft:master Mar 25, 2021

mkubilayk deleted the es-private-class-elements branch March 25, 2021 16:11

arciisine mentioned this pull request Apr 3, 2021

4.3.0 static #private incompatible with importHelpers and tslib 2.1 microsoft/TypeScript#43501

Closed

snyk-bot mentioned this pull request Apr 27, 2021

[Snyk] Upgrade tslib from 2.1.0 to 2.2.0 SalesforceCommerceCloud/commerce-sdk#327

Merged

renovate-bot mentioned this pull request May 21, 2021

Update dependency tslib to v2.2.0 ampproject/remapping#106

Closed

1 task

iChenLei mentioned this pull request Jun 23, 2021

chore: upgrade typescript/eslint related dependencies, drop node8 and add node16 CI support less/less.js#3628

Merged

This was referenced Jun 30, 2021

Update dependency tslib to v2.3.0 gregplaysguitar/react-object-input#28

Merged

chore(deps): update dependency tslib to v2 dwightjack/yuzu#35

Open

ci: update devDependencies ngxs-labs/storage-plugin-extension#8

Open

snyk-bot mentioned this pull request Jul 6, 2021

[Snyk] Upgrade tslib from 2.2.0 to 2.3.0 SalesforceCommerceCloud/commerce-sdk#330

Merged

pioter-pioter mentioned this pull request Jul 6, 2021

Update dependency tslib to v2 pioter-pioter/maply#35

Closed

1 task

mend-for-github-com bot mentioned this pull request Jul 7, 2021

Update dependency tslib to v2 wrbejar/LeakyAngularFromNotebook#127

Open

1 task

This was referenced Jul 8, 2021

Update dependency tslib to v2.3.0 faucetsdn/udmi#160

Closed

chore(deps): update dependency tslib to v2.3.0 (init) liesmich/liesmich#21

Merged

Update dependency tslib to v2.3.0 PsychoLlama/freeform-input#81

Merged

mend-for-github-com bot mentioned this pull request Jul 14, 2021

Update dependency tslib to v2 joshnewton31080/Angular-1#38

Open

1 task

This was referenced Jul 18, 2021

Update dependency tslib to v2.4.0 - autoclosed fdciabdul/Detektor-Wajah-Svelte#13

Closed

Update dependency tslib to v2 spences10/react-seo-component#111

Merged

Update dependency tslib to v2 hillnz/deadtous#19

Open

This was referenced Aug 5, 2021

Update dependency tslib to v2 weikangchia/op-converter#11

Merged

fix(deps): update dependency tslib to v2.3.1 donmahallem/block#155

Merged

jcesarioatpeach mentioned this pull request Jun 26, 2023

[Snyk] Upgrade tslib from 2.0.0 to 2.5.3 peachfinance/redoc#5

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update private class element helpers #146

update private class element helpers #146

mkubilayk commented Mar 23, 2021 •

edited

Loading

rbuckton commented Mar 25, 2021

rbuckton commented Apr 3, 2021

update private class element helpers #146

update private class element helpers #146

Conversation

mkubilayk commented Mar 23, 2021 • edited Loading

rbuckton commented Mar 25, 2021

rbuckton commented Apr 3, 2021

mkubilayk commented Mar 23, 2021 •

edited

Loading