Update package.json: changed pattern "./" to "./*" #135

NeizanSenpai · 2020-11-17T09:20:32Z

On Angular when executes command 'ng build --prod':

Generating browser application bundles...(node:16716) [DEP0148] DeprecationWarning: Use of deprecated folder mapping "./" in the "exports" field module resolution of the package at {{APP_PATH}}\node_modules\tslib\package.json.
Update this package.json to use a subpath pattern like "./*".
(Use node --trace-deprecation ... to show where the warning was created)

On Angular when executes command 'ng build --prod': - Generating browser application bundles...(node:16716) [DEP0148] DeprecationWarning: Use of deprecated folder mapping "./" in the "exports" field module resolution of the package at {{APP_PATH}}\node_modules\tslib\package.json. Update this package.json to use a subpath pattern like "./*". (Use `node --trace-deprecation ...` to show where the warning was created)

NeizanSenpai · 2020-11-17T09:34:12Z

I sent this change to fix the deprecation on new apps, this is a minor change. I don't undestand why test CI for 14.x failed.

orta · 2020-11-18T16:28:12Z

This can be rebased for the CI fix 👍🏻

Neizan93 · 2020-11-18T19:39:56Z

On Angular 11 + Node v15

On Angular when executes command 'ng build --prod':

Generating browser application bundles...(node:16716) [DEP0148] DeprecationWarning: Use of deprecated folder mapping "./" in the "exports" field module resolution of the package at {{APP_PATH}}\node_modules\tslib\package.json.
Update this package.json to use a subpath pattern like "./*".
(Use node --trace-deprecation ... to show where the warning was created)

Graphmaxer · 2020-12-02T14:47:38Z

Any update on this ? @Neizan-93 Can you rebase on master and after can we merge this. I'm having this warning with node 15.

rbuckton · 2021-01-05T19:07:55Z

I just closed #139 as a duplicate of this. In #139, the author points to postcss/postcss#1455, which tried to solve the deprecation in the same way. From the linked PR it sounds like this breaks NodeJS 12.x and there are still issues with it:

DeprecationWarning: Use of deprecated folder mapping "./" in the "exports" field module resolution of the package at G:\SNWS\sn-micro-front-web-project-template\node_modules\postcss\package.json. postcss/postcss#1455 (comment) (indicates errors in NodeJS 12, suggests adding both mappings)
DeprecationWarning: Use of deprecated folder mapping "./" in the "exports" field module resolution of the package at G:\SNWS\sn-micro-front-web-project-template\node_modules\postcss\package.json. postcss/postcss#1455 (comment) (seems to indicate using both mappings may reintroduce the warning in NodeJS 15)

@weswigham any thoughts?

rbuckton · 2021-01-05T19:10:20Z

@orta We are skipping esm node modules for NodeJS 12, so we're not seeing a possible error due to the fact NodeJS 12 supports subpath exports but not subpath patterns.

rbuckton · 2021-01-05T20:20:19Z

I've done some research and ~~cannot~~ can verify the issue mentioned in postcss/postcss#1455 (comment). With "./*": "./*", NodeJS 12.7 seems to work just fine (as long as --experimental-modules are passed to NodeJS), but NodeJS 12.18 (and possibly other versions I have not yet tested) have issues.

Update: NodeJS 12.20.1 seems to work fine with "./*": "./*", so it seems like they addressed this inconsistency in a patch.

The test case I used was:

// index.mjs
async function main() {
    // (a)
    try {
        const tslib1 = await import("tslib");
        console.log("default" in tslib1 ? "CommonJS" : "ESM");
    }
    catch (e) {
        console.error(e.name, e.message);
    }

    // (b)
    try {
        const tslib2 = await import("tslib/tslib.js");
        console.log("default" in tslib2 ? "CommonJS" : "ESM");
    }
    catch (e) {
        console.error(e.name, e.message);
    }

    // (c)
    try {
        const tslib3 = await import("tslib/tslib.es6.js");
        console.log("default" in tslib3 ? "CommonJS" : "ESM");
    }
    catch (e) {
        console.error(e.name, e.message);
    }

    // (d)
    try {
        const tslibpkg = await import("tslib/package.json");
        if (tslibpkg.default.name !== "tslib") throw new Error ("Unexpected result");
        console.log("ok");
    }
    catch (e) {
        console.error(e.name, e.message);
    }
}

main();

Results:

Version	Mapping	(a)	(b)	(c)	(d)
12.7.0	`"./"`	CommonJS	CommonJS	SyntaxError ¹	ok
12.7.0	`"./*""`	CommonJS	CommonJS	SyntaxError ¹	ok
12.18.3	`"./"`	ESM	CommonJS	SyntaxError ¹	TypeError ^{2, 3} / ok ⁴
12.18.3	`"./*"`	ESM	Error ⁵	Error ⁵	Error ^{3, 4, 5}
12.20.1	`"./"`	ESM	CommonJS	SyntaxError ¹	TypeError ^{2, 3} / ok ⁴
12.20.1	`"./*"`	ESM	CommonJS	SyntaxError ¹	TypeError ^{2, 3} / ok ⁴
15.4.0	`"./*"`	ESM	CommonJS	SyntaxError ¹	TypeError ^{2, 3} / ok ⁴

NOTES:

SyntaxError Unexpected token export - Loader tried to load ESM module as CommonJS
TypeError Unknown file extension ".json" - Loader won't load .json without --experimental-modules
Without --experimental-modules
With --experimental-modules
Error Package subpath '?' is not defined by "exports" - Loader won't load any subpath.

The most common use case for tslib is to just import the default export: Playground link. That means:

12.7.0 - Fails in both cases because its importing the CommonJS file, and thus all the exports are actually on the default export.
12.18.3 - Succeeds in both cases
12.20.1 - Succeeds in both cases
15.4.0 - Succeeds in both cases

However, subpath exports are trickier:

12.7.0 - Only loads as CommonJS in both cases
12.18.3
- "./" - Only loads subpath exports as CommonJS (fails for tslib/tslib.es.js, probably due to file extension)
- "./*" - Doesn't work at all.
12.20.1
- "./" - Only loads subpath exports as CommonJS (fails for tslib/tslib.es.js, probably due to file extension)
- "./*" - Only loads subpath exports as CommonJS (fails for tslib/tslib.es.js, probably due to file extension)
15.4.0
- "./" - Only loads subpath exports as CommonJS (fails for tslib/tslib.es.js, probably due to file extension), shows deprecation warning
- "./*" - Only loads subpath exports as CommonJS (fails for tslib/tslib.es.js, probably due to file extension)

The only consistency between 12.18 and 15.4 is "./", switching to "./*" would break anyone still using NodeJS 12.18 and subpath exports. At this time I'm not sure how impactful that break would be. NodeJS 12.20 seems to handle things correctly.

Since NodeJS 12 is a Maintenance LTS, is our stance to only support the latest version of a Maintenance LTS? If so, then this change is probably fine.

orta · 2021-01-06T09:32:20Z

@orta We are skipping esm node modules for NodeJS 12,

Interesting, I didn't know it was supported in 12 TBH.

I think it's pretty reasonable to assume here that the 12.18.x versions had a bug and we can add release notes stating they can update to a later version of 12.x to fix issues?

rbuckton · 2021-01-06T20:15:48Z

It was experimental in 12. I think this change is fine.

brunogrcsada · 2021-06-28T09:48:35Z

This really needs to be merged if possible @JonSenpai @rbuckton, there are quite a few dependencies that rely on tslib, and currently I'm facing a series of deprecation warnings during every build. I can just suppress it but it's not ideal :(

csvn · 2021-08-19T12:30:35Z

This PR should solve #152. Is there anything still blocking this from being merged?

Sidenote: Why is the ./* export even needed? All .js files in this repository are already being referenced by the conditional exports in the . path. Is there some other file that dependencies require from tslib?

package.json

RVledder · 2021-11-24T14:09:46Z

@csvn interesting approach using both syntaxes or exporting only the package.json.

Running the test script from @rbuckton on the current node version (17):

Version	Mapping	(a)	(b)	(c)	(d)
17.0.0	`"./": "./"` (current implementation)	ESM	Error ⁵	Error ⁵	Error ⁵
17.0.0	`"./package.json": "./package.json"`	ESM	Error⁵	Error ⁵	TypeError ²
17.0.0	`none`	ESM	Error ⁵	Error ⁵	TypeError ²
17.0.0	`"./": "./"`	ESM	CommonJS	SyntaxError ¹	TypeError ²

Seems like "./*": "./*" is a possible solution. But I'm not able to see why the CI has failed on the third job (14.x) since logs for this run have expired. And there might be some caveats (see my comment)

Made a proposal with explicitly defining the files here: #163

Note: Came across this thread after I created the PR and wasn't aware of the test script. Will run the same tests against that solution also, and post the results in the PR.

Co-authored-by: ExE Boss <[email protected]>

CobusKruger · 2022-02-08T08:43:28Z

@rbuckton do we know when the next release will be? It seems the last one was in August.

phocks · 2022-02-28T22:11:16Z

Current code is:
"./*": "./*", "./": "./"

VS Code seems to still complain, saying "Property ./ is not allowed."

Maybe should just be "./*": "./*" ?? ie. delete the last line

tslib/package.json

Line 36 in c827964

"./": "./"

(and the preceding comma)

Leaving ./ in there will still cause a warning I reckon as seen in microsoft#135

weswigham · 2022-02-28T22:42:50Z

./ is for old node, it's deprecated in new node, and thus not allowed by the json schema. It's safe to ignore. (New node will always match the * containing case first and so should never hit the deprecation warning for still having ./).

phocks · 2022-02-28T23:05:56Z

./ is for old node, it's deprecated in new node, and thus not allowed by the json schema. It's safe to ignore. (New node will always match the * containing case first and so should never hit the deprecation warning for still having ./).

Ah yes, now I get it. It's for backwards compatability. I'll ignore the VS Code warning. Thanks. Please ignore me :)

rbuckton mentioned this pull request Jan 6, 2021

#134 getting rid of deprecation warning #139

Closed

mxschmitt mentioned this pull request Apr 20, 2021

chore: fix deprecation warning with Node.js 16 imports microsoft/playwright#6248

Closed

tony mentioned this pull request Jul 11, 2021

DeprecationWarning: Use of deprecated folder mapping "./" in the "exports" field elastic/elasticsearch-js#1465

Closed

ExE-Boss reviewed Aug 19, 2021

View reviewed changes

package.json Outdated Show resolved Hide resolved

iomariani mentioned this pull request Sep 12, 2021

tslib DeprecationWarning with node v16 (15?) ezolenko/rollup-plugin-typescript2#267

Closed

donovanglover mentioned this pull request Sep 22, 2021

DeprecationWarning: Use of deprecated folder mapping "./" in the "exports" field antfu/prism-theme-vars#3

Closed

bjoluc mentioned this pull request Sep 30, 2021

Warning during builds in modularization jspsych/jsPsych#2180

Closed

bidoubiwa mentioned this pull request Oct 13, 2021

Update module import and export to remove DEP0148 depreciation warning meilisearch/meilisearch-js#1047

Closed

TheWirv mentioned this pull request Oct 29, 2021

DeprecationWarning: Use of deprecated folder mapping "./" in the "exports" field #134

Closed

RVledder mentioned this pull request Nov 24, 2021

Explicitly define exports for npm package, closes #134 #163

Closed

Use both export map syntaxes to support older NodeJS

3d5b50a

Co-authored-by: ExE Boss <[email protected]>

rbuckton approved these changes Feb 8, 2022

View reviewed changes

rbuckton merged commit 06853a8 into microsoft:main Feb 8, 2022

This was referenced Feb 8, 2022

fix node 16+ exports deprecation warning #167

Closed

Fix DeprecationWarning: Use of deprecated folder mapping #169

Closed

phocks added a commit to phocks/tslib that referenced this pull request Feb 28, 2022

Fix microsoft#135 properly

3767a03

Leaving ./ in there will still cause a warning I reckon as seen in microsoft#135

phocks mentioned this pull request Feb 28, 2022

Fix #135 properly #174

Closed

notjosh mentioned this pull request Apr 26, 2022

Fix instances of deprecated folder mapping within exports in package.json Shopify/ui-extensions#292

Merged

2 tasks

sync-by-unito bot mentioned this pull request May 1, 2022

build(deps): bump tslib from 2.3.1 to 2.4.0 numbersprotocol/capture-lite#1579

Closed

unicornware mentioned this pull request May 5, 2022

🐛 [DEP0148] DeprecationWarning: Use of deprecated folder mapping "./" flex-development/tutils#29

Closed

This was referenced May 7, 2022

node v17: Error loading tslib helper library ezolenko/rollup-plugin-typescript2#286

Closed

deps: upgrade tslib to ^2.4.0, remove @yarn-tool/resolve-package ezolenko/rollup-plugin-typescript2#326

Merged

marijnh mentioned this pull request Nov 7, 2022

Unable to run "prepare" script lezer-parser/markdown#21

Closed

saper mentioned this pull request Jun 21, 2024

Build failed in node 20 related to tslib stoplightio/elements#2582

Closed

jakebailey mentioned this pull request Jul 28, 2024

fix: remove generic package export #266

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update package.json: changed pattern "./" to "./*" #135

Update package.json: changed pattern "./" to "./*" #135

NeizanSenpai commented Nov 17, 2020

NeizanSenpai commented Nov 17, 2020

orta commented Nov 18, 2020

Neizan93 commented Nov 18, 2020

Graphmaxer commented Dec 2, 2020 •

edited

Loading

rbuckton commented Jan 5, 2021

rbuckton commented Jan 5, 2021

rbuckton commented Jan 5, 2021 •

edited

Loading

orta commented Jan 6, 2021

rbuckton commented Jan 6, 2021

brunogrcsada commented Jun 28, 2021 •

edited

Loading

csvn commented Aug 19, 2021

RVledder commented Nov 24, 2021 •

edited

Loading

CobusKruger commented Feb 8, 2022

phocks commented Feb 28, 2022 •

edited

Loading

weswigham commented Feb 28, 2022

phocks commented Feb 28, 2022

Update package.json: changed pattern "./" to "./*" #135

Update package.json: changed pattern "./" to "./*" #135

Conversation

NeizanSenpai commented Nov 17, 2020

NeizanSenpai commented Nov 17, 2020

orta commented Nov 18, 2020

Neizan93 commented Nov 18, 2020

Graphmaxer commented Dec 2, 2020 • edited Loading

rbuckton commented Jan 5, 2021

rbuckton commented Jan 5, 2021

rbuckton commented Jan 5, 2021 • edited Loading

orta commented Jan 6, 2021

rbuckton commented Jan 6, 2021

brunogrcsada commented Jun 28, 2021 • edited Loading

csvn commented Aug 19, 2021

RVledder commented Nov 24, 2021 • edited Loading

CobusKruger commented Feb 8, 2022

phocks commented Feb 28, 2022 • edited Loading

weswigham commented Feb 28, 2022

phocks commented Feb 28, 2022

Graphmaxer commented Dec 2, 2020 •

edited

Loading

rbuckton commented Jan 5, 2021 •

edited

Loading

brunogrcsada commented Jun 28, 2021 •

edited

Loading

RVledder commented Nov 24, 2021 •

edited

Loading

phocks commented Feb 28, 2022 •

edited

Loading