Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix broken build #922

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Docs: fix broken build #922

merged 2 commits into from
Nov 29, 2022

Conversation

adamjstewart
Copy link
Collaborator

@adamjstewart adamjstewart commented Nov 28, 2022

Documentation is failing to build on recent PRs:

WARNING: Pygments lexer name 'ipython3' is not known

I have no idea what changed since we lock down all direct dependencies. We'll see if this fixes the issue.

Related to spatialaudio/nbsphinx#24.

@adamjstewart
Copy link
Collaborator Author

I think I found the culprit, a bug in today's ipython release: ipython/ipython#13845

@adamjstewart adamjstewart marked this pull request as ready for review November 29, 2022 02:39
@calebrob6
Copy link
Member

Precise, I like it!

@calebrob6 calebrob6 merged commit 79bd54a into main Nov 29, 2022
@calebrob6 calebrob6 deleted the docs/ipython3 branch November 29, 2022 02:50
@adamjstewart
Copy link
Collaborator Author

adamjstewart commented Nov 29, 2022

We can remove this after the next ipython release. Technically, neither ipython nor ipywidgets are direct dependencies.

@calebrob6
Copy link
Member

Yeah, I saw one of the fixes use ipython!=8.7.0 and figured its better just to update next release. I added a reminder to my to-do list.

@adamjstewart adamjstewart added this to the 0.3.2 milestone Dec 9, 2022
@adamjstewart adamjstewart modified the milestones: 0.3.2, 0.4.0 Jan 23, 2023
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
* Docs: fix broken build

* try older ipython
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants