Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random GeoSamplers: add default length #755

Merged
merged 8 commits into from
Oct 1, 2022
Merged

Conversation

adamjstewart
Copy link
Collaborator

@adamjstewart adamjstewart commented Sep 3, 2022

Closes #380 @tritolol

Uses the same logic we use to compute GridGeoSampler length, updated by @remtav in #630

Has to wait until the 0.4.0 release since we add a new public function. We could make it private, but I wanted to render the math in the docs 😃

@adamjstewart adamjstewart added this to the 0.4.0 milestone Sep 3, 2022
@github-actions github-actions bot added samplers Samplers for indexing datasets testing Continuous integration testing labels Sep 3, 2022
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 3, 2022
@adamjstewart adamjstewart merged commit 598b702 into main Oct 1, 2022
@adamjstewart adamjstewart deleted the samplers/default-len branch October 1, 2022 21:35
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
* Random GeoSamplers: add default length

* Document sampler utilities

* Mypy fix

* Fix docs and tests

* Fix import order

* Fix rST link

* Document default length

* More clarification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation samplers Samplers for indexing datasets testing Continuous integration testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements to RandomBatchGeoSampler
2 participants