-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random GeoSamplers: add default length #755
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
samplers
Samplers for indexing datasets
testing
Continuous integration testing
labels
Sep 3, 2022
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Sep 3, 2022
calebrob6
reviewed
Sep 24, 2022
calebrob6
reviewed
Sep 30, 2022
adamjstewart
commented
Sep 30, 2022
calebrob6
approved these changes
Sep 30, 2022
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
* Random GeoSamplers: add default length * Document sampler utilities * Mypy fix * Fix docs and tests * Fix import order * Fix rST link * Document default length * More clarification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
samplers
Samplers for indexing datasets
testing
Continuous integration testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #380 @tritolol
Uses the same logic we use to compute
GridGeoSampler
length, updated by @remtav in #630Has to wait until the 0.4.0 release since we add a new public function. We could make it private, but I wanted to render the math in the docs 😃