Removing eval in model weight API #2323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most of this API was copied from torchvision, let me check what their code looks like these days. |
|
I wonder if we can use torchvision's |
|
I looked at the torchvision version (https://github.com/pytorch/vision/blob/main/torchvision/models/_api.py#L108) and it seems more hacky than what I've implemented here. I updated the PR description with more details. |
adamjstewart
previously approved these changes
Sep 28, 2024
adamjstewart
approved these changes
Sep 28, 2024
adamjstewart
added a commit
that referenced
this pull request
Oct 10, 2024
* Removing eval * Extend the model_weights dict with sub weights * Just search through the sub weights enum * Ruff * Fix bug and mypy * Test coverage * Formatting --------- Co-authored-by: Adam J. Stewart <[email protected]>
|
Published CVE for reference: https://www.cve.org/CVERecord?id=CVE-2024-49048 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing use of eval.
@nilsleh -- do you remember what the use case for eval was? If not, I say we replace all instances ofNevermind, I understand it now.get_weightwithget_model_weightsand removeget_weight.get_weight(...)allows a user to pass a string "ResNet18_Weights.LANDSAT_ETM_SR_MOCO" and get back the objectResNet18_Weights.LANDSAT_ETM_SR_MOCOWeightEnum. Previously we did this witheval("ResNet18_Weights.LANDSAT_ETM_SR_MOCO")which is bad. This proposed fix simply iterates through all available WeightEnums to look for matches and has the benefit of raising an error that makes sense if there is no match (vs. theeval(...)which would do whatever).