Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for pre-commit #1781

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Fix for pre-commit #1781

merged 1 commit into from
Dec 19, 2023

Conversation

ashnair1
Copy link
Collaborator

Type ignores added in 135f564 were not reflected in the pre-commit environment since scikit-image was not declared a dependency. This caused the mypy hook to fail with the following message:

pyupgrade................................................................Passed
isort....................................................................Passed
black....................................................................Passed
flake8...................................................................Passed
pydocstyle...............................................................Passed
mypy.....................................................................Failed
- hook id: mypy
- exit code: 1

torchgeo/datasets/vhr10.py:476: error: Unused "type: ignore" comment  [unused-ignore]
torchgeo/datasets/vhr10.py:528: error: Unused "type: ignore" comment  [unused-ignore]
Found 2 errors in 1 file (checked 292 source files)

@adamjstewart
Copy link
Collaborator

Can we also add pyvista to solve the vhr10 issue?

@adamjstewart adamjstewart self-assigned this Dec 19, 2023
@ashnair1
Copy link
Collaborator Author

The issue in vhr10 was due to scikit-image not being in the additional_dependencies section so it's solved now.

Also, pyvista is already in the list.

@adamjstewart adamjstewart added this to the 0.5.2 milestone Dec 19, 2023
@adamjstewart adamjstewart merged commit e572b74 into microsoft:main Dec 19, 2023
21 checks passed
@ashnair1 ashnair1 deleted the pre-commit-fix branch December 19, 2023 20:45
isaaccorley pushed a commit that referenced this pull request Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants