Update sourcegen #3880
Draft
Update sourcegen #3880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
reviewed
Sep 30, 2024
Evangelink
reviewed
Nov 5, 2024
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/NativeAotTests.cs
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
Nov 5, 2024
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/NativeAotTests.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Nov 5, 2024
| @@ -20,6 +20,7 @@ public class NativeAotTests : AcceptanceTestBase | |||
| <UseAppHost>true</UseAppHost> | |||
| <LangVersion>preview</LangVersion> | |||
| <PublishAot>true</PublishAot> | |||
| <NoWarn>$(NoWarn);IL2104;IL2026;IL3053</NoWarn> | |||
There was a problem hiding this comment.
Reminder to self: This should be removed before we can merge.
nohwnd
commented
Nov 5, 2024
Evangelink
reviewed
Nov 6, 2024
| @@ -3,14 +3,14 @@ | |||
| <!-- MSTest version --> | |||
| <VersionPrefix>3.7.0</VersionPrefix> | |||
| <!-- Testing Platform version --> | |||
| <TestingPlatformVersionPrefix>1.5.0</TestingPlatformVersionPrefix> | |||
| <TestingPlatformVersionPrefix>1.6.0</TestingPlatformVersionPrefix> | |||
There was a problem hiding this comment.
Needs to be reset
Suggested change
| <TestingPlatformVersionPrefix>1.6.0</TestingPlatformVersionPrefix> | |
| <TestingPlatformVersionPrefix>1.5.0</TestingPlatformVersionPrefix> |
| @@ -21,9 +21,9 @@ | |||
| <Uri>https://github.com/microsoft/testanywhere</Uri> | |||
| <Sha>4d80102c4530845265843db1454a4abda4128ba2</Sha> | |||
| </Dependency> | |||
| <Dependency Name="MSTest.Engine" Version="1.0.0-alpha.24473.2"> | |||
| <Dependency Name="MSTest.SourceGeneration" Version="1.0.0-alpha.24555.1"> | |||
There was a problem hiding this comment.
Let's sync versions:
Suggested change
| <Dependency Name="MSTest.SourceGeneration" Version="1.0.0-alpha.24555.1"> | |
| <Dependency Name="MSTest.SourceGeneration" Version="1.0.0-alpha.24554.7"> |
| <Uri>https://github.com/microsoft/testanywhere</Uri> | ||
| <Sha>aa2fcc8616d988b234bc1d218465b20c56d0b82f</Sha> | ||
| <Sha>3c99c34d0f99de8dacfe909073722bd8ba45f2d8</Sha> |
There was a problem hiding this comment.
Suggested change
| <Sha>3c99c34d0f99de8dacfe909073722bd8ba45f2d8</Sha> | |
| <Sha>4d80102c4530845265843db1454a4abda4128ba2</Sha> |
| <PreReleaseVersionLabel>preview</PreReleaseVersionLabel> | ||
| </PropertyGroup> | ||
| <PropertyGroup Label="MSTest prod dependencies - darc updated"> | ||
| <MicrosoftDotNetBuildTasksTemplatingPackageVersion>10.0.0-beta.24554.2</MicrosoftDotNetBuildTasksTemplatingPackageVersion> | ||
| <MicrosoftTestingExtensionsCodeCoverageVersion>17.13.0-preview.24555.1</MicrosoftTestingExtensionsCodeCoverageVersion> | ||
| <!-- comment to facilitate merge conflicts --> | ||
| <MicrosoftTestingInternalFrameworkVersion>1.5.0-preview.24554.7</MicrosoftTestingInternalFrameworkVersion> | ||
| <MSTestEngineVersion>1.0.0-alpha.24473.2</MSTestEngineVersion> | ||
| <MSTestSourceGenerationVersion>1.0.0-alpha.24555.1</MSTestSourceGenerationVersion> |
There was a problem hiding this comment.
Syncing versions
Suggested change
| <MSTestSourceGenerationVersion>1.0.0-alpha.24555.1</MSTestSourceGenerationVersion> | |
| <MSTestSourceGenerationVersion>1.0.0-alpha.24554.7</MSTestSourceGenerationVersion> |
| private static void AddFixtureTests(TestMethodInfo testMethodInfo, List<UnitTestElement> tests, HashSet<string> fixtureTests) | ||
| { | ||
| #if NET8_0_OR_GREATER |
There was a problem hiding this comment.
Could be NETCOREAPP or NET7_0_OR_GREATER if we want to link it specifically to native aot.
| public static void AddExtensions(ITestApplicationBuilder testApplicationBuilder, string[] arguments) => testApplicationBuilder.AddMSTest(() => [Assembly.GetEntryAssembly()!]); | ||
| public static void AddExtensions(ITestApplicationBuilder testApplicationBuilder, string[] arguments) | ||
| { | ||
| #if NET8_0_OR_GREATER |
There was a problem hiding this comment.
Could be NETCOREAPP or NET7_0_OR_GREATER if we want to link it specifically to native aot.
There was a problem hiding this comment.
IIRC it did not build with just netcoreapp, and net7 is out of life and rest of the platform used net8 so I used net8
Comment on lines
+6
to
+9
| <PropertyGroup Condition=" '$(IsTestApplication)' == 'true' "> | ||
| <EnableMSTestRunner>true</EnableMSTestRunner> | ||
| </PropertyGroup> | ||
|
|
Youssef1313
reviewed
Nov 7, 2024
There was a problem hiding this comment.
Note to self: Combine the tests in a single project so that we do the dotnet publish only once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.