Fix shutdown order for server mode #3306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 22, 2024 14:28
Evangelink
approved these changes
Jul 22, 2024
We cannot I did it manually simulating/reproing a throw new timeout. |
Evangelink
pushed a commit
that referenced
this pull request
Aug 5, 2024
Co-authored-by: Marco Rossignoli <[email protected]> # Conflicts: # samples/Playground/Playground.csproj # samples/Playground/Program.cs # samples/Playground/ServerMode/TestingPlatformClientFactory.cs # samples/Playground/ServerMode/v1.0.0/TestingPlatformClient.cs
Evangelink
modified the milestones:
MSTest 3.6 / Platform 1.4,
MSTest 3.5.3 / Platform 1.3.3
Evangelink
pushed a commit
that referenced
this pull request
Aug 30, 2024
Co-authored-by: Marco Rossignoli <[email protected]> # Conflicts: # samples/Playground/Playground.csproj # samples/Playground/Program.cs # samples/Playground/ServerMode/TestingPlatformClientFactory.cs # samples/Playground/ServerMode/v1.0.0/TestingPlatformClient.cs
Evangelink
modified the milestones:
MSTest 3.5.3 / Platform 1.3.3,
MSTest 3.6 / Platform 1.4
Evangelink
added a commit
that referenced
this pull request
Aug 30, 2024
This reverts commit f94d4b3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In server mode we cannot send back logging information to VS after the "exit".
cc: @drognanar