Fix assembly resolution error #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….MSTestAdapter.PlatformServices.resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force loading the resource assembly into the current domain so that we can get the resource strings even when the custom assembly resolver kicks in.
This should not be required based on the algorithm followed during the satellite assembly resolution BUT for some unknown reason the point 10 is not working as explained. Satellite resolution should fallback to the
NeutralResourcesLanguageAttributethat we set toenbut don't resulting in a FileNotFoundException.See #1598 for the error and microsoft/vstest#4150 for the idea of the fix.
Fixes #1598