Change ClassCleanup default behavior to be "EndOfClass" #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e5b5740.
Evangelink
reviewed
Jan 6, 2023
src/TestFramework/TestFramework/Attributes/Lifecycle/Cleanup/ClassCleanupBehavior.cs
Show resolved
Hide resolved
src/Adapter/MSTest.TestAdapter/PublicAPI/PublicAPI.Unshipped.txt
Outdated
Show resolved
Hide resolved
src/TestFramework/TestFramework/Attributes/Lifecycle/Cleanup/ClassCleanupExecutionAttribute.cs
Outdated
Show resolved
Hide resolved
test/IntegrationTests/MSTest.VstestConsoleWrapper.IntegrationTests/SuiteLifeCycleTests.cs
Show resolved
Hide resolved
Evangelink
reviewed
Jan 10, 2023
There was a problem hiding this comment.
A few more comments and we are good to go. Thanks for the work @engyebrahim
src/TestFramework/TestFramework/Attributes/Lifecycle/Cleanup/ClassCleanupBehavior.cs
Show resolved
Hide resolved
src/TestFramework/TestFramework/PublicAPI/PublicAPI.Unshipped.txt
Outdated
Show resolved
Hide resolved
Evangelink
approved these changes
Jan 10, 2023
engyebrahim
added a commit
to engyebrahim/testfx
that referenced
this pull request
May 16, 2023
…osoft#1538)" This reverts commit 2d2ab81. # Conflicts: # src/Adapter/MSTest.TestAdapter/PublicAPI/PublicAPI.Unshipped.txt
engyebrahim
added a commit
to engyebrahim/testfx
that referenced
this pull request
May 16, 2023
…osoft#1538)" This reverts commit 2d2ab81. # Conflicts: # src/Adapter/MSTest.TestAdapter/PublicAPI/PublicAPI.Unshipped.txt
engyebrahim
added a commit
that referenced
this pull request
May 17, 2023
This reverts commit 2d2ab81.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1316