Fix parallel output isolation (#1705)

microsoft · Jul 10, 2023 · 14b6245 · 14b6245
1 parent c570d67
commit 14b6245
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 11 deletions.
diff --git a/src/Adapter/MSTest.TestAdapter/Discovery/AssemblyEnumerator.cs b/src/Adapter/MSTest.TestAdapter/Discovery/AssemblyEnumerator.cs
@@ -4,6 +4,7 @@
 using System;
 using System.Collections.Generic;
 using System.Globalization;
+using System.IO;
 using System.Linq;
 using System.Reflection;
 using System.Runtime.Serialization;
@@ -271,7 +272,9 @@ private bool DynamicDataAttached(IDictionary<string, object?> sourceLevelParamet
             return false;
         }
 
-        using var writer = new ThreadSafeStringWriter(CultureInfo.InvariantCulture, "all");
+        // NOTE: From this place we don't have any path that would let the user write a message on the TestContext and we don't do
+        // anything with what would be printed anyway so we can simply use a simple StringWriter.
+        using var writer = new StringWriter();
         var testMethod = test.TestMethod;
         var testContext = PlatformServiceProvider.Instance.GetTestContext(testMethod, writer, sourceLevelParameters);
         var testMethodInfo = _typeCache.GetTestMethodInfo(testMethod, testContext, MSTestSettings.CurrentSettings.CaptureDebugTraces);

diff --git a/src/Adapter/MSTestAdapter.PlatformServices/Services/TestContextImplementation.cs b/src/Adapter/MSTestAdapter.PlatformServices/Services/TestContextImplementation.cs
@@ -32,7 +32,8 @@ public class TestContextImplementation : TestContext, ITestContext
     /// <summary>
     /// Writer on which the messages given by the user should be written.
     /// </summary>
-    private readonly ThreadSafeStringWriter _threadSafeStringWriter;
+    private readonly StringWriter _stringWriter;
+    private readonly ThreadSafeStringWriter? _threadSafeStringWriter;
 
     /// <summary>
     /// Test Method.
@@ -81,12 +82,11 @@ public TestContextImplementation(ITestMethod testMethod, StringWriter stringWrit
         DebugEx.Assert(stringWriter != null, "StringWriter is not null");
 #endif
 
-        DebugEx.Assert(stringWriter is ThreadSafeStringWriter, "Was expected stringWriter to be a ThreadSafeStringWriter");
-
         _testMethod = testMethod;
+        _stringWriter = stringWriter;
 
         // Cannot get this type in constructor directly, because all signatures for all platforms need to be the same.
-        _threadSafeStringWriter = (ThreadSafeStringWriter)stringWriter;
+        _threadSafeStringWriter = stringWriter as ThreadSafeStringWriter;
         _properties = new Dictionary<string, object?>(properties)
         {
             [FullyQualifiedTestClassNameLabel] = _testMethod.FullClassName,
@@ -172,7 +172,7 @@ public override void Write(string? message)
         try
         {
             var msg = message?.Replace("\0", "\\0");
-            _threadSafeStringWriter.Write(msg);
+            _stringWriter.Write(msg);
         }
         catch (ObjectDisposedException)
         {
@@ -196,7 +196,7 @@ public override void Write(string format, params object?[] args)
         try
         {
             string message = string.Format(CultureInfo.CurrentCulture, format.Replace("\0", "\\0"), args);
-            _threadSafeStringWriter.Write(message);
+            _stringWriter.Write(message);
         }
         catch (ObjectDisposedException)
         {
@@ -219,7 +219,7 @@ public override void WriteLine(string? message)
         try
         {
             var msg = message?.Replace("\0", "\\0");
-            _threadSafeStringWriter.WriteLine(msg);
+            _stringWriter.WriteLine(msg);
         }
         catch (ObjectDisposedException)
         {
@@ -243,7 +243,7 @@ public override void WriteLine(string format, params object?[] args)
         try
         {
             string message = string.Format(CultureInfo.CurrentCulture, format.Replace("\0", "\\0"), args);
-            _threadSafeStringWriter.WriteLine(message);
+            _stringWriter.WriteLine(message);
         }
         catch (ObjectDisposedException)
         {
@@ -334,15 +334,15 @@ public void AddProperty(string propertyName, string propertyValue)
     /// <returns>The test context messages added so far.</returns>
     public string? GetDiagnosticMessages()
     {
-        return _threadSafeStringWriter.ToString();
+        return _stringWriter.ToString();
     }
 
     /// <summary>
     /// Clears the previous testContext writeline messages.
     /// </summary>
     public void ClearDiagnosticMessages()
     {
-        _threadSafeStringWriter.ToStringAndClear();
+        _threadSafeStringWriter?.ToStringAndClear();
     }
 
     #endregion