Reduce instances of font fallback dialog #9734
Conversation
ghost
added
Area-Fonts
This comment has been minimized.
This comment has been minimized.
… variables to be nearby and not package related. add some doc comments.
|
Thanks for making it a magic static - that's way better |
ghost
added
the
Needs-Author-Feedback
|
"let me do my work," he says! Windows 7 is now that work |
ghost
removed
the
Needs-Author-Feedback
…p if we can't use the quick-convenience methods to create the font set from the files on disk.
|
|
@skyline75489 I appreciate that, and thanks for your work in #9201! I'm inclined to merge this one first just so that we can be ready for the 1.7 release (next week; hit me up on Teams for why this is important :)) and then get reviews in 9201. I know that it complicates your life because you have some merging to do 😦 and I am sorry about that. |
DHowett
changed the title
|
I tested ＭＳ ゴシック using WPF; it did not trigger the fallback code path. |
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
Reduce instances of font fallback dialog through package font loading, basic name trimming, and revised fallback test - Adjusts the font dialog to only show when we attempt last-chance resolution from our hardcoded list of font names with a flag instead of with a string comparison by name - Adds a resolution step to trim the font name by word from the end and retry to attempt to resolve a proper font that just has a weight suffix - Adds a second font collection to font loading that will attempt to locate all TTF files sitting next to our binary, like in our package - [x] Wrote my font preference in the JSON as `Cascadia Code Heavy` and watched it quietly resolve to just `Cascadia Code` without the dialog. - [x] Put a font that isn't registered with the system into the layout directory for the package, set it as my desired font in Terminal, and watched it load just fine. - [x] Try a font name with different casing and see if dialog doesn't pop anymore - [x] Try a font with different (localized) names like ＭＳ ゴシック and see if dialog doesn't pop anymore - [x] Check Win7 with WPF target Closes #9375 (cherry picked from commit 7f5a19b)
|
🎉 Handy links: |
|
🎉 Handy links: |
Reduce instances of font fallback dialog through package font loading,
basic name trimming, and revised fallback test
Adjusts the font dialog to only show when we attempt last-chance
resolution from our hardcoded list of font names with a flag instead
of with a string comparison by name
Adds a resolution step to trim the font name by word from the end and
retry to attempt to resolve a proper font that just has a weight
suffix
Adds a second font collection to font loading that will attempt to
locate all TTF files sitting next to our binary, like in our package
Wrote my font preference in the JSON as
Cascadia Code Heavyandwatched it quietly resolve to just
Cascadia Codewithout the dialog.Put a font that isn't registered with the system into the layout
directory for the package, set it as my desired font in Terminal, and
watched it load just fine.
Try a font name with different casing and see if dialog doesn't
pop anymore
Try a font with different (localized) names like ＭＳ ゴシック and
see if dialog doesn't pop anymore
Check Win7 with WPF target
Closes #9375