Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort fonts alphabetically #9653

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Sort fonts alphabetically #9653

merged 1 commit into from
Mar 29, 2021

Conversation

kovdu
Copy link
Contributor

@kovdu kovdu commented Mar 29, 2021 •
edited
Loading

PR Checklist

  • Closes Fonts in font face dropdown are not alphabetized #9594
  • [x ] CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Validated this only by following the issue description and verified fonts appeared to be sorted alphabetically now.

Happy to add automated tests as well but would need some help where to add these since I'm probably overlooking where fonts are covered now.

@ghost ghost added Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Mar 29, 2021
@ghost
Copy link

ghost commented Mar 29, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

DHowett
DHowett approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will definitely be better than what we had. Thank you!

All we need is for you to sign the CLA 😄

@DHowett DHowett changed the title Sort fonts alphabetically. Sort fonts alphabetically Mar 29, 2021
@kovdu
Copy link
Contributor Author

kovdu commented Mar 29, 2021

Just signed the CLA.
Happy to help out and was interesting to investigate and fix 🙂.

carlos-zamora
carlos-zamora approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@carlos-zamora carlos-zamora marked this pull request as ready for review March 29, 2021 22:35
@carlos-zamora carlos-zamora merged commit cf5dc28 into microsoft:main Mar 29, 2021
@ghost
Copy link

ghost commented Apr 14, 2021

🎉Windows Terminal Preview v1.8.1032.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Apr 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fonts in font face dropdown are not alphabetized
4 participants
@kovdu @DHowett @carlos-zamora @zadjii-msft